Effect Blacklisting

src/effects/builtin/builtinbackend.cpp

@@ -25,7 +25,7 @@
 #include "effects/builtin/tremoloeffect.h"
 
 BuiltInBackend::BuiltInBackend(QObject* pParent)
-        : EffectsBackend(pParent, tr("Built-in")) {
+        : EffectsBackend(pParent, "Built-in") {
     // Keep this list in a reasonable order
     // Mixing EQs
     registerEffect<Bessel4LVMixEQEffect>();

src/effects/defs.h

@@ -11,9 +11,10 @@ enum class EffectEnableState {
     Enabling
 };
 
-enum class EffectType {
+enum class BackendType {
     BuiltIn,
-    LV2
+    LV2,
+    Unknown
 };
 
 enum class SignalProcessingStage {

src/effects/effectmanifest.h

@@ -59,11 +59,15 @@ class EffectManifest final {
         }
     }
 
+    const BackendType& backendType() const {
+        return m_backendType;
+    }
     const QString& backendName() const {
         return m_backendName;
     }
     void setBackendName(const QString& name) {
-        m_backendName = name;
+        m_backendType = backendTypeFromString(name);
+        m_backendName = backendTypeToString(m_backendType);
     }
 
     const QString& author() const {
@@ -133,6 +137,28 @@ class EffectManifest final {
         m_metaknobDefault = metaknobDefault;
     }
 
+    static QString backendTypeToString(BackendType type) {
+        switch (type) {
+            case BackendType::BuiltIn:
+                //: Used for effects that are built into Mixxx
+                return QObject::tr("Built-in");
+            case BackendType::LV2:
+                return QObject::tr("LV2");
+            default:
+                //: Used for effects from unknown sources
+                return QObject::tr("Unknown");
+        }
+    }
+    static BackendType backendTypeFromString(const QString& name) {
+        if (name == "Built-in") {
+            return BackendType::BuiltIn;
+        } else if (name == "LV2") {
+            return BackendType::LV2;
+        } else {
+            return BackendType::Unknown;
+        }
+    }
+
   private:
     QString debugString() const {
         return QString("EffectManifest(%1)").arg(m_id);
@@ -141,8 +167,8 @@ class EffectManifest final {
     QString m_id;
     QString m_name;
     QString m_shortName;
+    BackendType m_backendType;
     QString m_backendName;
-    // QString m_backendName;
     QString m_author;
     QString m_version;
     QString m_description;

src/effects/lv2/lv2backend.cpp

@@ -2,7 +2,7 @@
 #include "effects/lv2/lv2manifest.h"
 
 LV2Backend::LV2Backend(QObject* pParent)
-        : EffectsBackend(pParent, tr("LV2")) {
+        : EffectsBackend(pParent, "LV2") {
     m_pWorld = lilv_world_new();
     initializeProperties();
     lilv_world_load_all(m_pWorld);

src/preferences/dialog/dlgprefeffects.cpp

@@ -19,7 +19,7 @@ DlgPrefEffects::DlgPrefEffects(QWidget* pParent,
         EffectManifestPointer pManifest = profile->pManifest;
 
         // Blacklisted Non-builtin effects by default
-        bool defaultValue = QString::localeAwareCompare(pManifest->backendName(), tr("Built-in")) == 0;
+        bool defaultValue = (pManifest->backendType() == BackendType::BuiltIn);
         bool visible = m_pConfig->getValue<bool>(ConfigKey("[Visible Effects]", 
                                                  pManifest->id()), defaultValue);
         profile->bIsVisible = visible;