LateNight :: optional Big spinnies, various improvements

[ronso0]

• choose Spinny, CoverArt or nothing (darker background makes Spinny indicator easier to recognize)
• choose big or small Spinny/CoverArt, from ywwg/latenight-biggerspinny
• add FX3/FX4 buttons to master mixer & Mic/Aux units
• clean up tool bar
• simplify skin setting buttons templates
• increase minimum window size to 1366x768px (1302,668px to consider Ubuntu's vertical taskbar)
• fix beatsize spinboxes for qt5
• persistent visibility connections in lower half (Mic/Aux, Samplers) Bug 1779575
• add Broadcast button to tool bar Bug 1776258
• add LateNight launch image
• add Load/Save Sampler Bank buttons
• fix control vinyl status light
• fix sampler VU meter graphics (wrong size of vector templates was exported to correct size in skin)
• show CUE point in samplers' overview Bug 1781830

(just an illustration..of course big/small spinny is toggled simultaneously on all decks)

New LateNight launch image:

Please test and let's discuss if we increase the minimum size to 1366x768 or if we stick with 1280px screens.

[nopeppermint]

@ronso0 looks good, thanks for keeping small cover Art ;-)

[ronso0]

looks good, thanks for keeping small cover Art ;-)

yeah, both 'big' and 'small' use cases are valid IMO.

[ywwg]

looks great thanks for picking this up!

[ronso0]

Done, please test.

[nopeppermint]

looks good

[nopeppermint]

maybe move "load/save sampler bank" to submenu "Sampler" ?

[ronso0]

We don't have a Samplers menu. Maybe we'll have one when we add more samplers or other sampler options, but for now I don't want to open another submenu just for this two buttons.

[ronso0]

Is anyone using controls vinyl? I don't so I can't test related controls and the status light

[ronso0]

@ywwg It feels strange that all buttons are dim when pressed. I'd like to change the icons so that the text is a bit brighter than unpressed. Do you mind?

[nopeppermint]

that all buttons are dim when pressed.

which buttons are dimmed?

[ronso0]

which buttons are dimmed?

all transport controls, rate buttons etc.
They are red/white text when active (i.e. HotCue is set) and get darker when you actually press them. IMO that doesn't match an action, i.e Play from cue, and I don't know of any hardware equivalent.

That's why I'd make the white text on 'active/set' buttons a tiny bit lesss bright, and the text/bg of such a pressed button brighter so pressed buttons stand up more.

[ywwg]

@ywwg It feels strange that all buttons are dim when pressed. I'd like to change the icons so that the text is a bit brighter than unpressed. Do you mind?

that's fine with me! I'd also be ok with replacing the pixmaps with font-based buttons, the design is a little out of place (as is the red color)

[ywwg]

Please test and let's discuss if we increase the minimum size to 1366x768 or if we stick with 1280px screens.

I think in the previous PR there was general consensus that 1366x768 would be ok. My old 1280 laptop is long dead, which is what I designed the original to fit. Did anyone else have an older machine that needed the smaller size? (In general, I think we should save Shade for the smallest screens)

[ronso0]

In general, I think we should save Shade for the smallest screens)

Yes, and actuallly all skins except LateNight fit on screens smaller than 1366px.
But now that the big spinnies are optional here I don't think we need to enforce a bigger skin size. It's much more comfortable when new features will be added, but for now I can as well revert it to 1280px.

[ronso0]

Re: Buttons redesign
I'd do this in a separate PR, and if I start it I'd also replace the inline WPushButtons with button templates. That'll make the skin templates much easier to read and maintain.

[nopeppermint]

@ronso0 why do you remove hover from star rating in decks?

[ronso0]

@ronso0 why do you remove hover from star rating in decks?

After quite a while I used LateNight for an actual prep session. Check new tracks, sort them into crates or just delete them, rate them! This is were I found the hover effect disturbing, (=unexpected) in LateNight. Can't tell why I implemented it in the first place.. it doesn't match the skin anyway and it's not significant enogh to help, it's just disturbing IMO.
The actual star widget has a hover effect itself, so I removed it.

[daschuer]

The minimum width has been increased. Now it does not fit next to the Ubuntu Unity task bar on my 1366x768 screen. This is not a strong requirement, but if we can make it fit again, it would be nice.

[daschuer]

I found myself repeated clicking on the top right gear button for skin settings.
Can we move the settings button there? We may also, or alternatively replace the gear button for the beatgrid with something else, a pencil icon, for "Edit beatgride" or something.

[ronso0]

The minimum width has been increased. Now it does not fit next to the Ubuntu Unity task bar on my 1366x768 screen

Good point! So we should update the skin_guidelines and add Ubuntu to the table.

Can we move the settings button there?

Nope, the space above decks is reserved for collapsible waveforms only.
I can replace the gear with a pencil or a wrench, like I suggested for Maintenance in lib-redesign branch. Also I'll try to add the gear icon to the Settings button. It makes sense to have this consistent across skins.

[daschuer]

Yes, thanks. My vote would be a pencil, because a wrench might be scared double left handed people. :-p

[daschuer]

1302,668
for Full HD Displays running Ubunty Unity.

[daschuer]

Than the EQ buttons are cutted with the Skin preferences visible though.
But the Mixxx is usable on my device now.
If we consider the "preferences open" state as exceptional it should work.

[ronso0]

1366x768 is just HD (720+ lines)
actually I never really cared about squeezed skins with Pref pane open.
btw. there's no way to fit Deere or Tango with Skin Settings open on a 1024px screen
as long as the skin fits in its regular state where fine I think.

[daschuer]

There is only the pending size issue, the rest LGTM

[ronso0]

My vote would be a pencil, because a wrench might be scared double left handed people. :-p

ha! I know what you mean..and was curious how to translate the german phrase. dict.leo.org says
"folks how are all thumbs"
so let's remove the gear as well, and the faders, all that stuff that MUST be something technical

[daschuer]

Thanks!

[Be-ing]

The minimum width and height are too wide to fit my 3840 x 2160 screen now (using Qt5's automatic scaling) :/

[Be-ing]

I tried cherry-picking d8b5714 to 2.1 but without the skin settings menu, there isn't enough horizontal space in the toolbar...

[ronso0]

there isn't enough horizontal space in the toolbar...

Whaaat?

It's not realistic to test all skins with X screen resolutions and if automatic scaling fails so badly with 4K, we should bring back the possibility to opt out IMO

[Be-ing]

There is enough horizontal space in the toolbar for the broadcast icon in 2.2, but 2.1 has more buttons in the toolbar because it does not have the skin settings menu.

Automatic scaling works well. Why was the minimum size increased in this PR? LateNight worked fine on my screen before. The minimum size should be as small as possible, not just to fit in the widest variety of screen sizes, but also so Mixxx can be run more comfortably in a window that is not full screen.

[ronso0]

LateNight 2.1.0 Besides the question why you would import the broadcast button into 2.1, I see there's enough space for it at minimal window size:

The minimum width and height are too wide to fit my 3840 x 2160 screen now (using Qt5's automatic scaling) :/

Please post a screenshot to show what is squeezed. Or is it just the warning in Prefences > Interface?
And yes, I consider Qt Scaling failing if it can't put a skin designed for 1366px on a 4K screen.

The minimum size was increased after we (incl. you) decided to do so in #1734.
This way we can have bigger spinnies AND a usable artist/title box.

also so Mixxx can be run more comfortably in a window that is not full screen.

That's why I decreased it after @daschuer noticed it wouldn't fit next to the Ubuntu taskbar.

[ronso0]

Damn, I now notice this should actuallly go to 2.2 to have consitent Spinny/CoverArt controls.
@Be-ing @daschuer Do you agree? If yes, how to merge this into 2.2?
Edit just pulled 2.2 and noitce this is already included...?

Also I'll soon open a small-fix PR to clean up the spinny COs in Deere so they really match those implemented here that should go to 2.2, as well.

[daschuer]

Edit just pulled 2.2 and noitce this is already included...?

Yes, currently 2.2 and master are the same.