save and restore horizontal scroll bar during sorting #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no pressing need to merge this to 2.1, changed target to master. |
|
Actually, I think it's fine to merge this bug fix to 2.2. But there is no good reason to risk destabilizing 2.1 for this. |
ronso0
reviewed
Aug 28, 2018
src/widget/wtracktableview.cpp
Outdated
| @@ -1736,22 +1737,16 @@ void WTrackTableView::doSortByColumn(int headerSection) { | |||
| } | |||
|
|
|||
| // Save the selection | |||
| const QList<TrackId> trackIds = getSelectedTrackIds(); | |||
| const QList<TrackId> slectedTrackIds = getSelectedTrackIds(); | |||
There was a problem hiding this comment.
consistent typo: selectedTrackIds
|
Done! |
|
merge? |
|
LGTM and works as expected 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://bugs.launchpad.net/mixxx/+bug/1789134