Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aliasing violations when using SampleUtil::copy2WithGain. Bug #1770771. #1807

Merged
merged 1 commit into from Sep 15, 2018
Merged

Fix aliasing violations when using SampleUtil::copy2WithGain. Bug #1770771. #1807

merged 1 commit into from Sep 15, 2018

Conversation

rryan
Copy link
Member

@rryan rryan commented Sep 15, 2018

No description provided.

@rryan
Copy link
Member Author

rryan commented Sep 15, 2018

It would be nice if Travis offered something newer than Ubuntu Trusty (!) 😠 so that we could get a newer compiler. Uwe noticed this with GCC 8.

@daschuer
Copy link
Member

LGTM, Thank you.

@Be-ing
Copy link
Contributor

Be-ing commented Sep 15, 2018

Is there something wrong with the SampleUtil::copy2WithGain function? Should that be fixed or should the function be removed?

@Be-ing Be-ing closed this Sep 15, 2018
@Be-ing
Copy link
Contributor

Be-ing commented Sep 15, 2018

Ugh, why is there a "Close and comment" button?!

@Be-ing Be-ing reopened this Sep 15, 2018
@daschuer
Copy link
Member

The issue happens due to the M_RESTRICT keyword that promises that the pointer regions are not overlapping to allow the compiler to vectorize the loops. This was not true in the removed cases.

@rryan
Copy link
Member Author

rryan commented Sep 15, 2018

Is there something wrong with the SampleUtil::copy2WithGain function? Should that be fixed or should the function be removed?

Nope, it was just being called incorrectly. It's a shame that we don't get a compilation error in this case though.

@rryan
Copy link
Member Author

rryan commented Sep 15, 2018

Thanks for the review!

@rryan rryan merged commit c133c2f into mixxxdj:2.1 Sep 15, 2018
@rryan rryan deleted the alias branch September 17, 2018 23:47
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rryan @daschuer @Be-ing