lp1793387: Abort decoding/reading of corrupt MP3 files #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uklotzde
changed the title
|
I can confirm that the crash is fixed. On one hand it is a pity that we refuse to play files that can be played elsewhere, but on the other hand I don't want these loud artifacts blow my PA system or the audience ears, so it is just fine for Mixxx. LGTM just waiting for CI |
|
I love you guys! The only thing that matters is that Mixxx doesn't crash when loading a file while playing live. |
|
Can this be cherry picked into the 2.2 branch? |
|
Done. You can also do that locally on a personal branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1793387