Create a 'libmixxx.a' static library which mixxx and mixxx-test link. #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rryan
force-pushed
the
scons
branch
2 times, most recently
from
9499b17
to
2ec3274
Compare
|
CI looks good, and most of the dupe environment warnings are gone on Windows. There are still some related to SoundTouch being used in both the VAMP plugins and mixxx. |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix "duplicate environment" warnings we get on Windows and removes the dependency on gmock, gtest, and benchmark when building with
test=1.Fixes Bug #1151646.