Update controllerdebug.h to unqouted output for mixxx.log #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banad60
changed the title
banad60
changed the title
|
Thank you! Could you please sign the Mixxx contributor agreement? This gives us permissions to distribute your change. |
rryan
reviewed
Oct 20, 2018
| @@ -33,7 +33,7 @@ class ControllerDebug { | |||
| #define controllerDebug(stream) \ | |||
There was a problem hiding this comment.
if you could add a comment above this line mentioning Bug #1797746 and why the noquote is present that would be nice to avoid accidental removals
There was a problem hiding this comment.
done! sorry for my poor english.
|
Please rebase on the 2.2 branch and retarget this PR to 2.2. Switching the target branch of this PR didn't work as expected. |
banad60
force-pushed
the
patch-1
branch
3 times, most recently
from
25588ae
to
8e75f0c
Compare
Fix for https://bugs.launchpad.net/mixxx/+bug/1797746 Without this patch, debugging messages in mixxx.log are quoted since QT > 5.4, which breaks output of engine.log() escape characters. This patch adds .noquote() to QDebug if QT_VERSION >= 5.4
|
Thank you for rebasing. @banad60 can you confirm that you have signed the contributor agreement linked above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since qt5, QDebug sems quoted by default. But for debugging we need unquoted output in mixxx.log