make better use of intro/outro markers with AutoDJ #2103

Be-ing · 2019-05-06T21:55:13Z

and add a checkbox to revert to the old behavior that does not use the
new intro/outro markers at all. With the box checked (which is the
default), AutoDJ uses the outro of the outgoing track or the intro of
the incoming track for the transition time, whichever is longer. If only
one track has these marked, use that track's marked transition time. If
neither track has the intro/outro range marked, fall back to the fixed
number of seconds specified by the spinbox. If users do not want to
interrupt the workflow they are accustomed to when upgrading to Mixxx
2.3, they can simply uncheck the new box.

and add a checkbox to revert to the old behavior that does not use the new intro/outro markers at all. With the box checked (which is the default), AutoDJ uses the outro of the outgoing track or the intro of the incoming track for the transition time, whichever is longer. If only one track has these marked, use that track's marked transition time. If neither track has the intro/outro range marked, fall back to the fixed number of seconds specified by the spinbox. If users do not want to interrupt the workflow they are accustomed to when upgrading to Mixxx 2.3, they can simply uncheck the new box.

Be-ing · 2019-05-06T21:57:32Z

With this new behavior, if a user does not put in the effort to manually mark intro end and outro start markers, AutoDJ works just as it did before but with the added benefit of cutting out silence.

uklotzde · 2019-05-06T22:13:33Z

I suggest using the shorter duration of both outro and intro instead. Otherwise you risk to cut off the main part from one of the tracks. The silence part after the outro end and before the intro start is already excluded, so you will never get silence during a transition.

uklotzde · 2019-05-06T22:17:31Z

Counter example when using the longer duration: A track with a long instrumental outro (30 sec) will play over the first verse of the next track with a short intro (3 sec).

Be-ing · 2019-05-06T22:21:47Z

Otherwise you risk to cut off the main part from one of the tracks.

I don't understand. In what scenario could anything be cut off?

Counter example when using the longer duration: A track with a long instrumental outro (30 sec) will play over the first verse of the next track with a short intro (3 sec).

Yes, that is what I intended. I initially tried choosing the shorter duration, but thought the longer one generally worked better. I suppose there are use cases for both, depending on the intended effect. How about turning the new checkbox into a 3 state combobox?

Do not use intro/outro markers
Use shorter of intro/outro sections
Use longer of intro/outro sections

uklotzde · 2019-05-06T22:56:08Z

The crossfade phase should be short since we don't have beat nor phrase synchronization. If I enable AutoDJ I don't expect long, sophisticated mixes, but instead predictable behavior and pleasant results without periods of silence while playing unattended.

I don't expect that the long duration will be used frequently, but the short duration is mandatory for me. How about offering both and collecting feedback? Removing an option later is not very user-friendly, but I don't want to exclude any of those options upfront.

uklotzde · 2019-05-06T22:59:43Z

The longer duration may work for extend mixes or ambient styles, but definitely not for a mixture of short radio edits and only a few tracks with extended intros or outros (as found on album versions).

daschuer · 2019-05-06T23:23:04Z

For me it is unclear what to mark as intro. I think we need a clear definition to make subsumptions how the Auto DJ should deal with it.

The markers are named "intro start" and "intro end" where "intro start" id by default the first notable sound. You reuse the markers her as fade start and fade end. This is a fundamental difference.

A extreme is for example:
fury in the slaughterhouse - time to wonder
https://www.youtube.com/watch?v=qk7Xt4X0qyw

The intro is 1:06 than guitar to 1:38 and than vocal starts.

In Juke box mode may I like to play the track from the start. For DJ-Ing I have a CUE point placed at the first beat after 1:06. All works fine in Mixxx 2.2.

-2 s transition and load at start for Juke box
4 s transition and load at CUE for DJ-ing

How can I achieve the same in Mixxx 2.3?

Starting from the first sound instead of 0:00 is a nice feature. No manual track editing required.
If I am annoyed from a long intro even in Juke-Box mode I can shift the "intro start".

What is the "intro end" then?
I may place it at 1:06, and it becomes a "DJ-Mode Load CUE"
Or I can place it at 1:38 and it becomes a "End transition here!" warning
Or I can place start and end marker after 1:06 .. 1:10 to define an individual fade in region.

ronso0 · 2019-05-06T23:27:54Z

I suggest using the shorter duration of both outro and intro instead. Otherwise you risk to cut off the main part from one of the tracks

..except when both outro and intro are equally long AutoDJ would always play over the main part of one track. I can't imagine how this could be intended.
What are the use cases for using the longer in/outro?

Can we use radio buttons O CUE point [spinbox] sec. and O Intro/outro range and put both choices in the AutoDJ feature in the skin?

ninomp · 2019-05-06T23:44:03Z

@Be-ing I don't see that you change SeekOnLoad mode of decks -- tracks will still be loaded at Intro Start.

src/library/autodj/dlgautodj.cpp

This allows for completely ignoring the intro/outro markers with AutoDJ.

and rename some code for clarity

Be-ing · 2019-05-07T04:49:25Z

@daschuer:
Mark the part of the track you want to mix in as the intro. That can be anywhere in the track; it is up to you. If you want AutoDJ to ignore the intro & outro markers, choose that mode in the new combobox in the AutoDJ library feature. When this mode is selected and AutoDJ is active, tracks load now at the beginning (as they did before #1242 was merged). The preference option to choose where to seek tracks upon loading is overridden by AutoDJ when AutoDJ is enabled. I have added a third option for this preference so tracks can be loaded at the intro start for manual DJing.

If you want AutoDJ to use the main cue points you have already set, I think the best way to do that would be setting the intro start point to those cue points. Perhaps you could add a button in the AutoDJ preference window to do this for the whole library. We could then remove the button for 2.4 as it should only be needed for migrating to 2.3. We should not assume how users have used the main cue point in the past, so I think this should be manually triggered by the user. Going forward, I don't think AutoDJ should have anything to do with the main cue point (which is the current state in this branch).

@uklotzde, @ronso0:
I still do not understand what you mean by cutting off parts of tracks. If you can find a way to make that happen with this branch, please explain. Screenshots would be helpful.

Be-ing · 2019-05-07T04:53:08Z

The default for the new combobox in the AutoDJ library feature is to use the shorter of the intro/outro. Using the longer of the intro/outro is still an option. After factoring out some repeated code into functions, maintaining both is rather simple.

(I know the tests are not working now. I want to reach a consensus on the desired behavior before fixing those.)

Be-ing · 2019-05-07T05:09:04Z

src/engine/controls/cuecontrol.cpp

+    case SeekOnLoadMode::Beginning:
+        // This allows users to load tracks and have the needle-drop be maintained.
+        if (!(m_pVinylControlEnabled->get() &&
+                m_pVinylControlMode->get() == MIXXX_VCMODE_ABSOLUTE)) {


I'm not sure if this should be checked for any other SeekOnLoadModes. @ywwg maybe you can clarify?

Be-ing · 2019-05-07T06:02:07Z

Maybe we should call AutoDJ SemiautoDJ now :P IMO this is more useful than what any other DJ software does.

daschuer · 2019-05-07T06:50:29Z

Mark the part of the track you want to mix in as the intro. That can be anywhere in the track; it is up to you.

This way the term intro is just wrong. In the DJ use case, I don't want to use a long intro, just because the previous track as a short outro for transition.

This way we reuse the intro start amend markers as "transition start" and "transition end".

We may rename these markers, but in this case we loose the original intro region, which is useful for the juke box use case and for visualisation during DJing.

If you want AutoDJ to ignore the intro & outro markers, choose that mode in the new combobox in the AutoDJ library feature.

I have no option there for load at "first sound" if we reuse the markers like above.

The preference option to choose where to seek tracks upon loading is overridden by AutoDJ when AutoDJ is enabled.

I think changing the load behavior according to the AutoDj was a bad decision.
We always use the AutoDJ as it would be a real DJ. We have even a Bug to have Auto DJ always on. I strongly recommend to follow this paradigm. This keeps finally the ability to interact smoothly with the AutoDj without hidden magic.

I have added a third option for this preference so tracks can be loaded at the intro start for manual DJing.

Thank you.

If you want AutoDJ to use the main cue points you have already set, I think the best way to do that would be setting the intro start point to those cue points.

Nooo. You cannot require every user to do that for all tracks in Library. Imagine somone installs Mixxx 2.3 without doing this. The gig will be a mass.

We need a Auto DJ mode loading at Cue.
And thus should be default, if load at cue was selected in 2.2.

Perhaps you could add a button in the AutoDJ preference window to do this for the whole library.

This breaks the new and IMHO important silent detection feature.

We should not assume how users have used the main cue point in the past, so I think this should be manually triggered by the user.

We can if the track was loaded at cue. It was used as load cue than.

Going forward, I don't think AutoDJ should have anything to do with the main cue point (which is the current state in this branch).

It should. It is my use case. How do you use the cue point? Something else than cue-ing a new track in? Please explain, so I can understand your needs.

How will the Juke box use case work finally?

Be-ing · 2019-05-07T07:06:56Z

I have no option there for load at "first sound" if we reuse the markers like above.

I think the only way to do that would be to add new cues for the autodetected first/last sounds independent of the intro/outro ranges and set the intro start/outro end to these autodetected points by default (as they are currently). These new first/last sound points could potentially be hidden and read-only to avoid complicating the UI. If AutoDJ uses those when not using the intro/outro ranges, that breaks one of my use cases (playing an album straight through with transition time 0, including all silence as it is on the album), so I think a 4th AutoDJ mode would be needed.

How do you use the cue point?

The cue point is merely where I last pressed play. Nothing more. If Mixxx interprets my main cue points as having any more meaning than that, it will be wrong and likely sound bad.

daschuer · 2019-05-07T11:25:03Z

How do you use the cue point?

The cue point is merely where I last pressed play. Nothing more. If Mixxx interprets my main cue points as having any more meaning than that, it will be wrong and likely sound bad.

So you load a track always at start, in 2.2. right? I think you and me are presenting the two different typical users then.

Do you use Denon Cue mode, for moving cue with play?

I am in a good mood that it should be able to find a solution for both with a limited number of extra options and no addition GUI clutter.

"tio" was a legacy name for TrackInfoObject, which is now just Track

This will allow for adding a new AutoDJ fade mode that skips silence regardless of where the intro/outro markers are.

also some renaming and refactoring

Be-ing · 2019-05-07T19:31:22Z

I have added new FirstSound and LastSound cue types independent of the Intro/Outro cues. The intro start/outro end are placed at the same point as these by AnalyzerSilence, but the FirstSound and LastSound cues do not move when the user adjusts the intro/outro cues. I have added a new AutoDJ mode to skip silence with a fixed fade time. This is the only change to the GUI for these new cue types; they are not shown on the waveforms or editable by the user.

daschuer · 2019-05-07T19:50:46Z

Thank you for the work. I an not sure if this is a good solution, it might be finally. But let's first define a solution that works for us both. Currently I am in doubt that these new hidden cues work. I will prepare a post with the requirements we have so far.

…t updated lenght info when updating outro start.

daschuer · 2019-11-10T02:04:46Z

Another try:
Be-ing#38

quantisation fix + cue fix + git-clang-format

daschuer · 2019-11-10T11:07:14Z

Everything green finally. LGTM

uklotzde · 2019-11-11T21:51:03Z

What's the different between HotCue and Jump? From my understanding these terms are used synonymously. Cue::Type::Jump is unused in Mixxx.

In aoide I prefer to use the shorter term Jump for HotCue position markers. Just noticed this while adjusting the mapping.

Be-ing · 2019-11-11T21:54:46Z

You're right, Cue::Type::Jump is unused. We may as well rename it to Cue::Type::Placeholder.

uklotzde · 2019-11-11T22:16:13Z

I've chosen a different naming for the position markers in aoide, but the mapping is straightforward:

//const int kPositionMarkerCustom = 0; // unused/unsupported
const int kPositionMarkerLoad = 1; // = Cue::Type::MainCue
const int kPositionMarkerMain = 2; // = Cue::Type::AudibleSound
const int kPositionMarkerIntro = 3;
const int kPositionMarkerOutro = 4;
const int kPositionMarkerJump = 5; // = Cue::Type::HotCue
const int kPositionMarkerLoop = 6;
//const int kPositionMarkerSample = 7; // unused/unsupported

The most notable difference is that in aoide Load is the "main" cue point with the initial position after loading while Main is supposed to be a range, i.e. the audible/main part of the track.

daschuer · 2019-11-11T22:25:45Z

Cue::Type::Jump was planed to be a jump cue, a kind of reverse loop to automatically jump over a region, in the track.

Where do the aoide definitions come from?

uklotzde · 2019-11-11T22:42:12Z

Intuition, practical experience, some research. Unfortunately, I have not collected the sources. The intention was to cover the common use cases without introducing any conflicting or redundant definitions.

Be-ing · 2019-11-11T22:43:25Z

Can we continue this conversation on Zulip? This is off topic from this PR.

uklotzde · 2019-11-11T22:45:23Z

So Mixxx::Jump == Serato::Flip. Not supported by aoide yet.

Closed.

Holzhaus · 2019-11-11T23:35:00Z

Serato Flip works differently, it supports multiple jumps at different positions.

Holzhaus · 2020-07-08T14:46:03Z

src/library/autodj/autodjprocessor.cpp

+                // outro of the fromDeck track is longer than the whole toDeck
+                // track
+                outroLength = pToDeck->fadeBeginPos - introStart;
+                VERIFY_OR_DEBUG_ASSERT(outroLength > 0) {


This debug assertion is triggered inside a lot of the AutoDJ processor tests: https://travis-ci.org/github/mixxxdj/mixxx/jobs/705774858#L2692
You notice it when compiling with #2911.

@daschuer You introduced this assertion in 010fd5c and know the AutoDJ code better than I do. Can you have a look?

Or maybe @Be-ing check this?

Be-ing mentioned this pull request May 6, 2019

Intro/Outro cues and silence detection #1242

Merged

15 tasks

add option to choose shorter or longer of intro/outro for AutoDJ

7163fd3

Be-ing commented May 6, 2019

View reviewed changes

src/library/autodj/dlgautodj.cpp Outdated Show resolved Hide resolved

Be-ing added 3 commits May 6, 2019 21:20

convert SeekOnLoadMode to enum class

7cfe38e

don't load at intro start when not using intro/outro with AutoDJ

febce9b

This allows for completely ignoring the intro/outro markers with AutoDJ.

add option to load tracks at intro start marker

450d409

and rename some code for clarity

Be-ing commented May 7, 2019

View reviewed changes

Be-ing added 5 commits May 7, 2019 11:31

convert Cue::CueType to enum class

c45b27f

convert Cue::CueSource to enum class

580c20b

rename tio -> pTrack in AnalyzerSilence

bad1178

"tio" was a legacy name for TrackInfoObject, which is now just Track

add new FirstSound/LastSound cues separate from Intro/Outro

648aaa7

This will allow for adding a new AutoDJ fade mode that skips silence regardless of where the intro/outro markers are.

add new AutoDJ mode that skips silence with fixed fade time

6532bd7

also some renaming and refactoring

daschuer added 2 commits November 10, 2019 00:20

git-clang-format

ea3f2b9

Fix a bug where outro end was passed the end of the track, because no…

082e2e6

…t updated lenght info when updating outro start.

Merge pull request #38 from daschuer/autodj_intro_outro

1ab1853

quantisation fix + cue fix + git-clang-format

daschuer approved these changes Nov 10, 2019

View reviewed changes

daschuer merged commit b4c9ca1 into mixxxdj:master Nov 10, 2019

Be-ing deleted the autodj_intro_outro branch November 11, 2019 21:53

ehendrikd added a commit to ehendrikd/mixxx that referenced this pull request Nov 12, 2019

Updates to compile with mixxxdj#2103

11a5729

Be-ing mentioned this pull request Nov 12, 2019

use QColor for cue colors #2345

Closed

ronso0 mentioned this pull request Nov 16, 2019

Skins :: adjust styles of skin context menus, tooltip… 2nd attempt #2363

Merged

10 tasks

Be-ing mentioned this pull request Jan 18, 2020

use QColor for cue colors (rebased) #2399

Closed

1 task

Holzhaus added this to Done in 2.3 release Mar 14, 2020

Holzhaus reviewed Jul 8, 2020

View reviewed changes

daschuer mentioned this pull request Aug 13, 2023

AutoDJ don't fallback on crossfade time when intro or outro is not set #11648

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make better use of intro/outro markers with AutoDJ #2103

make better use of intro/outro markers with AutoDJ #2103

Be-ing commented May 6, 2019

Be-ing commented May 6, 2019

uklotzde commented May 6, 2019

uklotzde commented May 6, 2019 •

edited

Be-ing commented May 6, 2019

uklotzde commented May 6, 2019

uklotzde commented May 6, 2019

daschuer commented May 6, 2019

ronso0 commented May 6, 2019 •

edited

ninomp commented May 6, 2019

Be-ing commented May 7, 2019 •

edited

Be-ing commented May 7, 2019 •

edited

Be-ing May 7, 2019

Be-ing commented May 7, 2019

daschuer commented May 7, 2019

Be-ing commented May 7, 2019

daschuer commented May 7, 2019

Be-ing commented May 7, 2019

daschuer commented May 7, 2019

daschuer commented Nov 10, 2019

daschuer commented Nov 10, 2019

uklotzde commented Nov 11, 2019

Be-ing commented Nov 11, 2019

uklotzde commented Nov 11, 2019

daschuer commented Nov 11, 2019

uklotzde commented Nov 11, 2019

Be-ing commented Nov 11, 2019

uklotzde commented Nov 11, 2019

Holzhaus commented Nov 11, 2019

Holzhaus Jul 8, 2020

Holzhaus Jul 10, 2020

make better use of intro/outro markers with AutoDJ #2103

make better use of intro/outro markers with AutoDJ #2103

Conversation

Be-ing commented May 6, 2019

Be-ing commented May 6, 2019

uklotzde commented May 6, 2019

uklotzde commented May 6, 2019 • edited

Be-ing commented May 6, 2019

uklotzde commented May 6, 2019

uklotzde commented May 6, 2019

daschuer commented May 6, 2019

ronso0 commented May 6, 2019 • edited

ninomp commented May 6, 2019

Be-ing commented May 7, 2019 • edited

Be-ing commented May 7, 2019 • edited

Be-ing May 7, 2019

Choose a reason for hiding this comment

Be-ing commented May 7, 2019

daschuer commented May 7, 2019

Be-ing commented May 7, 2019

daschuer commented May 7, 2019

Be-ing commented May 7, 2019

daschuer commented May 7, 2019

daschuer commented Nov 10, 2019

daschuer commented Nov 10, 2019

uklotzde commented Nov 11, 2019

Be-ing commented Nov 11, 2019

uklotzde commented Nov 11, 2019

daschuer commented Nov 11, 2019

uklotzde commented Nov 11, 2019

Be-ing commented Nov 11, 2019

uklotzde commented Nov 11, 2019

Holzhaus commented Nov 11, 2019

Holzhaus Jul 8, 2020

Choose a reason for hiding this comment

Holzhaus Jul 10, 2020

Choose a reason for hiding this comment

uklotzde commented May 6, 2019 •

edited

ronso0 commented May 6, 2019 •

edited

Be-ing commented May 7, 2019 •

edited

Be-ing commented May 7, 2019 •

edited