Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrestrained multi-threaded analysis #2142

Merged
merged 1 commit into from Jun 10, 2019
Merged

Unrestrained multi-threaded analysis #2142

merged 1 commit into from Jun 10, 2019

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Jun 4, 2019

Removes the last remaining obstacle.

@uklotzde uklotzde added this to the 2.3.0 milestone Jun 4, 2019
@uklotzde uklotzde changed the title Finish multi-threaded analysis Unrestrained multi-threaded analysis Jun 5, 2019
@uklotzde
Copy link
Contributor Author

uklotzde commented Jun 9, 2019

Ping. I still get reproducible key analysis results after removing this last workaround.

@daschuer
Copy link
Member

Jippie! LGTM, Thank you.

@daschuer daschuer merged commit 21e3031 into mixxxdj:master Jun 10, 2019
@Be-ing
Copy link
Member

Be-ing commented Jun 10, 2019

I ran analyses on two new databases and the results seem to be consistent. 👍 This doesn't seem to have increased analysis speed (by much) compared to master before this was merged. It took about 1.5 hours for 4516 tracks with my Intel Core i7 8550U.

@uklotzde uklotzde deleted the multithreaded_qm_key_analyzer branch June 12, 2019 08:18
@Holzhaus Holzhaus added this to Done in 2.3 release Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.3 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants