Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix time offset in key and beat analysis #2152

Merged
merged 14 commits into from
Aug 8, 2019
Merged

Fix time offset in key and beat analysis #2152

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
169ca80
make sure first sample is sentered in the fft window to fix start ofs…
daschuer Jun 9, 2019
1ce3e74
Show key occurrence in debug message as seconds
daschuer Jun 9, 2019
ca7055a
remove special case of window size = step size. This uses a diffrent …
daschuer Jun 10, 2019
1c0a248
revert rename, now back to Histogram
daschuer Jun 12, 2019
6ec246f
use c++11 assign() and remove obsolete const parameter
daschuer Jun 13, 2019
67d8ecc
Remove undocumented offset in qm beat detector
daschuer Jun 18, 2019
9939dbd
pass last partial chunk to the analyzer as well. Fixes lp1833306
daschuer Jun 18, 2019
0af3ddd
Pad the last buffer for analysis with zeros to allow to analyze it as…
daschuer Jun 25, 2019
0d3ca5f
Merge remote-tracking branch 'upstream/master' into analyzer_start
daschuer Jun 26, 2019
b099b7a
Use math_max() and improve comments
daschuer Jul 3, 2019
944702c
Check first detected beat for plausibility
daschuer Jul 2, 2019
e5f7548
Improve comments.
daschuer Jul 21, 2019
e1351b7
Fix copy and past typo
daschuer Jul 21, 2019
a84bfc2
shift beatgrid 1/2 step size to the front, since the actual beat can …
daschuer Jul 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/analyzer/plugins/buffering_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,11 @@ bool DownmixAndOverlapHelper::processStereoSamples(const CSAMPLE* pInput, size_t
bool DownmixAndOverlapHelper::finalize() {
// We need to append at least m_windowSize / 2 - m_stepSize silence
// to have a valid analysis results for the last track samples.
// Since we go in fixed steps up to "m_stepSize - 1" samples remains
// unrocessed. That th reason we use "m_windowSize / 2 - 1" below
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor typos in comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping

// instead of "m_windowSize / 2 - m_stepSize"
size_t framesToFillWindow = m_windowSize - m_bufferWritePosition;
size_t numInputFrames = framesToFillWindow;
if (numInputFrames < m_windowSize / 2 - 1) {
// -1 ensures that silence < m_stepSize ramains unprocessed
numInputFrames = m_windowSize / 2 - 1;
}
size_t numInputFrames = math_max(framesToFillWindow, m_windowSize / 2 - 1);
return processInner(nullptr, numInputFrames);
}

Expand Down