Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable battery widget in Tango skin #2277

Merged
merged 1 commit into from Sep 14, 2019
Merged

Conversation

rrrapha
Copy link
Contributor

@rrrapha rrrapha commented Sep 10, 2019

It looks like this:
preview

preview

@ronso0
Copy link
Member

ronso0 commented Sep 11, 2019

Thank you for the effort of rotating the icons.
However, the widget is too small IMO, especially for the club use case where the conditions/stress level is a bit rough and the screen might be further away.

I think we can use the regular vertical icons you created for Deere, there's enough space between the Broadcasting indicator and the clock.

@rrrapha
Copy link
Contributor Author

rrrapha commented Sep 11, 2019

Thanks for your comment, do you mean something like this?

preview

preview
(I'm unsure about the colors)

@ronso0
Copy link
Member

ronso0 commented Sep 11, 2019

Yeah that'll work I guess. Looks a bit like a bottle of milk, but heij :)

regarding the colors: after merge I'll test it and see if the red is sufficiently warning or if the low bat needs an additional colored outline.

Thank you!

@ronso0
Copy link
Member

ronso0 commented Sep 11, 2019

just testing, I think 24x24 is sufficient. Also, the icons look sharp then @100% scaling (icons are 48px)

image

@Be-ing
Copy link
Member

Be-ing commented Sep 14, 2019

LGTM thank you. How about LateNight and Shade?

@Be-ing Be-ing merged commit 228e612 into mixxxdj:master Sep 14, 2019
@nopeppermint
Copy link
Contributor

How about LateNight and Shade?

latenight #2281

@poelzi
Copy link
Contributor

poelzi commented Sep 15, 2019

how about changing empty part of the battery in color, not the full one. this way it become visually more dominant that it's nearly empty.

@Be-ing
Copy link
Member

Be-ing commented Sep 15, 2019

I think that would be confusing. I've never seen a battery indicator on any OS that works that way.

@ronso0
Copy link
Member

ronso0 commented Sep 15, 2019

I also think we should stick to that convention.
but we may try what I proposed above: color the outline of the empty battery part like the remaining part, maybe also make the outline a bit thicker.

ic_battery_discharging_1 svg

@daschuer
Copy link
Member

On my mobile the empty bat has an empty red outlined inner border, I like that.
Or this: https://icon-library.net/icon/iphone-battery-charging-icon-27.html

@rrrapha rrrapha deleted the battery-tango branch September 20, 2019 10:14
@Holzhaus Holzhaus added this to Done in 2.3 release Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.3 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants