lp1846971: Fix database inconsistencies caused by LibraryScanner #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are many more database inconsistencies that pile up over time and that might cause any kind of undefined behavior. But I'm not able to invest a huge amount of time to satisfy the requirements of all stakeholders. |
|
Found another bug 3-year-old bug report that confirms this issue: https://bugs.launchpad.net/mixxx/+bug/1603348 The attached database shows the same inconsistencies. |
uklotzde
changed the title
|
Thank you for scaling back the scope of this. This looks like a reasonable way to handle those severe bugs. |
|
LGTM, Thank you. |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1846971
Mitigates serious bug reported in:
https://bugs.launchpad.net/mixxx/+bug/1603348
https://bugs.launchpad.net/mixxx/+bug/1846775 (very likely)
https://bugs.launchpad.net/mixxx/+bug/1846945 (marked as duplicate)
This is just a workaround and does not fix the actual cause for those inconsistencies! Restarting Mixxx and rescanning the library should discover the previously unreachable and ignored files.
Runs concurrently in the LibraryScanner thread and does not slow down the startup.