Refactoring: Attach WTrackTableView to Library instead of TrackCollection #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing, because I'm not able to keep waiting on this to get merged. Keeping multiple branches consistent is a waste of effort. I'm keeping my personal fork for refactoring the library code. |
|
Sorry for not being able to review and test this in time. I am currently reviewing #2336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup after support for external track collections has been added. A straight-forward refactoring, no functional changes:
TrackCollectionup intoLibraryMore to follow. The dependency hell around
TrackCollectionandLibraryis ridiculous and complicates any future enhancements.