Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Reduce dependencies on TrackDAO #2344

Closed
wants to merge 4 commits into from
Closed

Refactoring: Reduce dependencies on TrackDAO #2344

wants to merge 4 commits into from

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Nov 2, 2019 •
edited
Loading

Another attempt to reduce some dependencies within the library. TrackDAO should primarily be accessed by TrackCollection or LibraryScanner.

No functional changes, except:

  • The processCoverArt parameter was redundant as true was the only value that was passed

@uklotzde uklotzde changed the title Reduce dependencies on TrackDAO Refactoring: Reduce dependencies on TrackDAO Nov 2, 2019
@uklotzde uklotzde mentioned this pull request Nov 10, 2019
Closed
@uklotzde
Copy link
Contributor Author

Closing, because I'm not able to keep waiting on this to be merged.

@uklotzde uklotzde closed this Nov 11, 2019
@uklotzde uklotzde deleted the trackcollection_trackdao branch November 12, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@uklotzde