Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rgb presentation for cue colors with "no color" migration #2398

Closed
wants to merge 49 commits into from
Closed

Use rgb presentation for cue colors with "no color" migration #2398

wants to merge 49 commits into from

Commits on Nov 21, 2019

  1. Create HotcueColorPalette class

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    be0f798 View commit details
    Browse the repository at this point in the history

  2. Add methods to store QColor in the config

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    ff6602c View commit details
    Browse the repository at this point in the history

  3. Add class to store HotcueColorPalette in userconfig

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    594e091 View commit details
    Browse the repository at this point in the history

  4. Add tests for color config methods

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    746a2d0 View commit details
    Browse the repository at this point in the history

  5. Make Cue related code use QColor 

    .. instead of PredefinedColorPointer.

COs and the database now hold the color hex int representation instead of a color id.
    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    6816b04 View commit details
    Browse the repository at this point in the history

  6. Migrate hotcue color id to RGBA in DB

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    5d05386 View commit details
    Browse the repository at this point in the history

  7. Remove PredefinedColorRepresentation

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    1263a48 View commit details
    Browse the repository at this point in the history

  8. Make UserSettings available in ControllerEngine

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    1243b80 View commit details
    Browse the repository at this point in the history

  9. Remove PredefinedColors from controller scripts 

    ... and use QColor instead.
    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    6c45087 View commit details
    Browse the repository at this point in the history

  10. Remove PredefinedColor

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    c1ecfe1 View commit details
    Browse the repository at this point in the history

  11. Update midi-components library 

    and change cue color CO name
    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    81db977 View commit details
    Browse the repository at this point in the history

  12. Avoid constructing HotcueColorPaletteSettings every time its used

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    d58fadb View commit details
    Browse the repository at this point in the history

  13. Change test names

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    cfd7b15 View commit details
    Browse the repository at this point in the history

  14. Reorder constructor parameters

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    6447375 View commit details
    Browse the repository at this point in the history

  15. Rename member variable

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    4f1e138 View commit details
    Browse the repository at this point in the history

  16. Rename some color related classes

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    db0d7fe View commit details
    Browse the repository at this point in the history

  17. Remove cues tab on TrackInfo

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    7d4f254 View commit details
    Browse the repository at this point in the history

  18. Add QColorDialog to ColorMenu

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    2572916 View commit details
    Browse the repository at this point in the history

  19. Set hotcue color to the first predefined color

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    46c02fd View commit details
    Browse the repository at this point in the history

  20. Set hotcue color CO to -1 when no hotcue is loaded

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    06f6750 View commit details
    Browse the repository at this point in the history

  21. Make hotcue skin buttons use the cue color 

    Shade still does not work
    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    e67a6ed View commit details
    Browse the repository at this point in the history

  22. Pass UserSettings to Controller constructor

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    cdc40f4 View commit details
    Browse the repository at this point in the history

  23. Format code

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    23caf07 View commit details
    Browse the repository at this point in the history

  24. Rename members

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    5b9f08b View commit details
    Browse the repository at this point in the history

  25. Change string literal

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    2120185 View commit details
    Browse the repository at this point in the history

  26. Allow skins to configure text color depending on background

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    374e779 View commit details
    Browse the repository at this point in the history

  27. Highlight hotcue buttons when hovered

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    a5ee198 View commit details
    Browse the repository at this point in the history

  28. Fix Shade hotcue buttons color

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    a0646fa View commit details
    Browse the repository at this point in the history

  29. Make hotcue button hover highlighting configurable

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    2688916 View commit details
    Browse the repository at this point in the history

  30. Fix auto_hotcue_colors not assigning first color

    @ferranpujolcamins @daschuer
    ferranpujolcamins authored and daschuer committed Nov 21, 2019
    Configuration menu
    Copy the full SHA
    844ab4c View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2019

  1. Use orange as default Cue color, keep Black as default in database an… 

    …d keep track of the default state of the cue color.
    @daschuer
    daschuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    c96bc32 View commit details
    Browse the repository at this point in the history

  2. Respect auto_hotcue_colors when loading cues from database

    @daschuer
    daschuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    c64ff42 View commit details
    Browse the repository at this point in the history

  3. Move getDefaultColor() to HotcueColorPaletteSettings

    @daschuer
    daschuer committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    73339cf View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Merge remote-tracking branch 'upstream/master' into new_colors_impl2

    @daschuer
    daschuer committed Dec 14, 2019
    Configuration menu
    Copy the full SHA
    c70b66c View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2020

  1. Merge remote-tracking branch 'upstream/master' into new_colors_impl2

    @daschuer
    daschuer committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    ba0e9b3 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2020

  1. Mask alpha channel and use light weight QRgb where possible

    @daschuer
    daschuer committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    d314ac3 View commit details
    Browse the repository at this point in the history

  2. Allow to select a default color

    @daschuer
    daschuer committed Jan 2, 2020
    Configuration menu
    Copy the full SHA
    8cdf264 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2020

  1. Use Skin default hot cue color by default

    @daschuer
    daschuer committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    227b702 View commit details
    Browse the repository at this point in the history

  2. Fix merge issues with LatNight skin

    @daschuer
    daschuer committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    f07ff0d View commit details
    Browse the repository at this point in the history

  3. Store selected default color as cue color

    @daschuer
    daschuer committed Jan 4, 2020
    Configuration menu
    Copy the full SHA
    11421fc View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. Show message box that explains storing the default Hotcue color

    @daschuer
    daschuer committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    86b1fcc View commit details
    Browse the repository at this point in the history

  2. Show colors in hotcue default color combobox

    @daschuer
    daschuer committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    4818acf View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2020

  1. Merge remote-tracking branch 'upstream/master' into new_colors_impl2

    @daschuer
    daschuer committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    42c6c01 View commit details
    Browse the repository at this point in the history

  2. Added colorconfig_test to CMakeList.txt and fix it

    @daschuer
    daschuer committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    06014b1 View commit details
    Browse the repository at this point in the history

  3. define the off palette default color at a single place

    @daschuer
    daschuer committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    ddfbf1b View commit details
    Browse the repository at this point in the history

  4. Added HotcueColorPaletteSettings::PaletteIndex

    @daschuer
    daschuer committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    3d96a85 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Improve default cue explaination text.

    @daschuer
    daschuer committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    098fdcf View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into new_colors_impl2

    @daschuer
    daschuer committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    5405487 View commit details
    Browse the repository at this point in the history

  3. Fix readability and other minor changes

    @daschuer
    daschuer committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    5b589cf View commit details
    Browse the repository at this point in the history