Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use local variables by reference #2475

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Don't use local variables by reference #2475

merged 1 commit into from
Jan 31, 2020

Conversation

daschuer
Copy link
Member

@Holzhaus Holzhaus added this to the 2.3.0 milestone Jan 30, 2020
@Holzhaus
Copy link
Member

Sorry, looks like that was introduced in PR #2427.

@uklotzde
Copy link
Contributor

LGTM. AppVeyor build failure is unrelated.

@uklotzde uklotzde merged commit 9a5c566 into mixxxdj:master Jan 31, 2020
@Holzhaus Holzhaus added this to Done in 2.3 release Mar 14, 2020
@daschuer daschuer deleted the lp1861421 branch September 26, 2021 17:37
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
critical bug
Projects
No open projects
2.3 release
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daschuer @Holzhaus @uklotzde