util/compatibility: Don't use pass-by-copy in atomic helper functions #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @ronso0 to check if this also fixes https://bugs.launchpad.net/mixxx/+bug/1860808. For some reason I still can't add you as a reviewer. :( |
uklotzde
reviewed
Feb 1, 2020
Holzhaus
force-pushed
the
atomic-fixes
branch
from
ee06c94
to
564423e
Compare
uklotzde
approved these changes
Feb 1, 2020
|
Ping @daschuer? |
|
FYI both versions fixed the clone position issue. |
maybe because I didn't join the dev team, yet. |
|
OK in this case. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here: #2423 (comment)