Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Column Improvements #2487

Merged
merged 4 commits into from Feb 5, 2020

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Feb 4, 2020

  • Add header for the sample rate column (which is already defined)
  • Add sort column ID for the sample rate column
  • Hide sample rate and bpm_lock column by default (bpm lock state can be seen via the BpmDelegate anyway)

@daschuer
Copy link
Member

daschuer commented Feb 5, 2020

Should it be possible to show the sample rate column? I have no idea how.

@daschuer
Copy link
Member

daschuer commented Feb 5, 2020

I am not able to show the default hidden colums by the library header context menu.
It this intended? Where can I select them?

@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 5, 2020

I think they can only be shown if the associated column is also selected from the DB, which is not the case right now (and that also explains why nobody noticed that the sample rate column has no column header text). So, I don't think that this PR has any impact on the normal Mixxx library at the moment. But the Serato library (PR #2480) has a samplerate and bpm_lock column, so it will work there.

@daschuer
Copy link
Member

daschuer commented Feb 5, 2020

OK, the code looks good so lets merge it.

@daschuer daschuer merged commit 9c0ba25 into mixxxdj:master Feb 5, 2020
@RafaelFrance
Copy link
Contributor

Please do not hide the lock_bpm column. I use it all time as a mark when I prepare my music playlist to mark what I have recently played.
A least let the choice to select Hidden/Visible.
Thanks

@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 6, 2020

Please do not hide the lock_bpm column. I use it all time as a mark when I prepare my music playlist to mark what I have recently played.
A least let the choice to select Hidden/Visible.

You can still right click the column headers and enable the column. But I doubt you're using the BPM lock column. I guess you're probably using the normal bpm column which has a small lock icon that toggles bpm_lock.

@RafaelFrance
Copy link
Contributor

Yes, I use the small lock icon near the bpm value. Sorry for the misunderstanding.

I know it is a strange way to use this icon, but I try to not play same tracks on dance events where I DJ regularly. So I mark tracks with lock icon on History playlists of the event and so I know which one to avoid to play.

Thanks

@Holzhaus
Copy link
Member Author

Holzhaus commented Feb 6, 2020

Mixx also has a "Played" column that shows the playcount. And in the future you'll also be able to mark individual track with colors (#2470) :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants