Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotcue RGB colors #2520

Merged
merged 164 commits into from
Mar 16, 2020
Merged

Hotcue RGB colors #2520

merged 164 commits into from
Mar 16, 2020

Commits on Feb 28, 2020

  1. Create HotcueColorPalette class

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    75e6e2a View commit details
    Browse the repository at this point in the history

  2. Add methods to store QColor in the config

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    393ac12 View commit details
    Browse the repository at this point in the history

  3. Add class to store HotcueColorPalette in userconfig

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    42a22b0 View commit details
    Browse the repository at this point in the history

  4. Add tests for color config methods

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    86bda12 View commit details
    Browse the repository at this point in the history

  5. Make Cue related code use QColor instead of PredefinedColorPointer 

    COs and the database now hold the color hex int representation instead
of a color id.
    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    48b2b02 View commit details
    Browse the repository at this point in the history

  6. Migrate hotcue color id to RGBA in DB

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    fcb4a1d View commit details
    Browse the repository at this point in the history

  7. Remove PredefinedColorRepresentation

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    c22b737 View commit details
    Browse the repository at this point in the history

  8. Make UserSettings available in ControllerEngine

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    f017447 View commit details
    Browse the repository at this point in the history

  9. Remove PredefinedColors from controller scripts 

    ... and use QColor instead.
    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    f68f28c View commit details
    Browse the repository at this point in the history

  10. Remove PredefinedColor

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    66d3ffa View commit details
    Browse the repository at this point in the history

  11. Update midi-components library 

    and change cue color CO name
    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    30b82cf View commit details
    Browse the repository at this point in the history

  12. Avoid constructing HotcueColorPaletteSettings every time its used

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    1a3b8aa View commit details
    Browse the repository at this point in the history

  13. Change test names

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    7a5d13f View commit details
    Browse the repository at this point in the history

  14. Reorder constructor parameters

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    23e114f View commit details
    Browse the repository at this point in the history

  15. Rename member variable

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    0ef7da4 View commit details
    Browse the repository at this point in the history

  16. Rename some color related classes

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    bbc4503 View commit details
    Browse the repository at this point in the history

  17. Remove cues tab on TrackInfo

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    2259321 View commit details
    Browse the repository at this point in the history

  18. Set hotcue color to the first predefined color

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    e1f92ec View commit details
    Browse the repository at this point in the history

  19. Set hotcue color CO to -1 when no hotcue is loaded

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    413c17c View commit details
    Browse the repository at this point in the history

  20. Make hotcue skin buttons use the cue color 

    Shade still does not work
    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    74b098c View commit details
    Browse the repository at this point in the history

  21. Allow skins to configure text color depending on background

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    75fdbed View commit details
    Browse the repository at this point in the history

  22. Highlight hotcue buttons when hovered

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    7702c6c View commit details
    Browse the repository at this point in the history

  23. Fix Shade hotcue buttons color

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    738db3a View commit details
    Browse the repository at this point in the history

  24. Make hotcue button hover highlighting configurable

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    123172c View commit details
    Browse the repository at this point in the history

  25. Fix auto_hotcue_colors not assigning first color

    @ferranpujolcamins @Holzhaus
    ferranpujolcamins authored and Holzhaus committed Feb 28, 2020
    Configuration menu
    Copy the full SHA
    f3153b7 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2020

  1. Migrate hotcue color logic to mixxx::RgbColor

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    39928d6 View commit details
    Browse the repository at this point in the history

  2. engine/controls/cuecontrol: Use constant for no color control value

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f259558 View commit details
    Browse the repository at this point in the history

  3. Use *value instead of value.value() for std::optional

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    5732911 View commit details
    Browse the repository at this point in the history

  4. Fix RgbColor typecasts and range checks

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    fafe58b View commit details
    Browse the repository at this point in the history

  5. engine/controls/cuecontrol: Pass RgbColor by value

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    37133d9 View commit details
    Browse the repository at this point in the history

  6. color/colorpalette: Improve readability by adding names to constants

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    ac28f21 View commit details
    Browse the repository at this point in the history

  7. src/controllers/colorjsproxy: Add nearestColorMidiCode function

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    a477c87 View commit details
    Browse the repository at this point in the history

  8. res/controllers/midi-components: Update HotcueButton to use new API

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    d803ea8 View commit details
    Browse the repository at this point in the history

  9. Roland DJ-505: Update controller script for new color API

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    78c5101 View commit details
    Browse the repository at this point in the history

  10. src/controllers/colorjsproxy: Fix indentation in colorDistance function

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    080663c View commit details
    Browse the repository at this point in the history

  11. src/controllers/colorjsproxy: Add comment to colorDistance algorithm

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    3864c80 View commit details
    Browse the repository at this point in the history

  12. src/controllers: Add ColorMapper class for controller scripts

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    16a4778 View commit details
    Browse the repository at this point in the history

  13. .eslintrc.json: Add ColorMapper class to globals

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    b3b9c0d View commit details
    Browse the repository at this point in the history

  14. res/controllers/midi-components: Add support for ColorMapper class

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    d4a0508 View commit details
    Browse the repository at this point in the history

  15. Roland DJ-505: Add support for ColorMapper class

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e1cc9be View commit details
    Browse the repository at this point in the history

  16. controllers/colormapperjsproxy: Add separate getNearestValue method

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f97a15b View commit details
    Browse the repository at this point in the history

  17. Roland DJ-505: Switch to ControllerMapper::getNearestValue

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f8ccbcd View commit details
    Browse the repository at this point in the history

  18. controllers/midi-components: Remove default value for HotcueButton.co… 

    …lors
    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    8fe1bd2 View commit details
    Browse the repository at this point in the history

  19. controllers/midi-components: Rename HotcueButton.colors to .colorMapper

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    f313cc7 View commit details
    Browse the repository at this point in the history

  20. res/controllers/midi-components-0.0: Fix some eslint issues

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    1dad294 View commit details
    Browse the repository at this point in the history

  21. Roland DJ-505: Rename Component.colors to .colorMapper

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    09f6982 View commit details
    Browse the repository at this point in the history

  22. util/color: Remove obsolete hotcuecolorpalette.h file

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    5da79b0 View commit details
    Browse the repository at this point in the history

  23. widget/wcolorpicker: Remove use of std::optional::value()

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    7e90a64 View commit details
    Browse the repository at this point in the history

  24. widget: Add ColorPalette support to WColorPicker

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    6c8496f View commit details
    Browse the repository at this point in the history

  25. preferences: Make HotcuePaletteSettings support other palette types, too

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    8a4e87d View commit details
    Browse the repository at this point in the history

  26. util/color/colorpalette: Add support for a dedicated track color palette

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    df91a83 View commit details
    Browse the repository at this point in the history

  27. widget/wcolorpicker: Determine best number of columns for palette size

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    dac8810 View commit details
    Browse the repository at this point in the history

  28. engine/controls/cuecontrol: Add some debug asserts for color conversions

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    0e27925 View commit details
    Browse the repository at this point in the history

  29. engine/control/cuecontrol: Add helper func to convert RgbColor values

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    327702e View commit details
    Browse the repository at this point in the history

  30. engine/controls/cuecontrol: Fix wrong color index in hotcueFocusColor… 

    …Prev
    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e964345 View commit details
    Browse the repository at this point in the history

  31. Roland DJ-505: Fix eslint issues in controller script

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    a2d789c View commit details
    Browse the repository at this point in the history

  32. res/skins: Fix trailing whitespace errors in style.qss files

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    982f7b7 View commit details
    Browse the repository at this point in the history

  33. controllers/controller: Fix end-of-line linter issues

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e8ce23e View commit details
    Browse the repository at this point in the history

  34. preferences/configobject: Replace mixxx::RgbColor::optional_t with op… 

    …tional
    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    4938898 View commit details
    Browse the repository at this point in the history

  35. widget/cuemenupopup: Remove usage of std::optional::value()

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    ba3b84d View commit details
    Browse the repository at this point in the history

  36. Do not pass RgbColor/RgbColor::optional_t by reference

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    11935e2 View commit details
    Browse the repository at this point in the history

  37. preferences/configobject: Use RgbColor conversion functions

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    74e884a View commit details
    Browse the repository at this point in the history

  38. widget/wcolorpicker: Add tooltip to color picker

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    d54fd95 View commit details
    Browse the repository at this point in the history

  39. controllers: Remove obsolete ColorJSProxy

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    709cb3f View commit details
    Browse the repository at this point in the history

  40. controllers/colormapperjsproxy: Remove alpha channel from JS script c… 

    …olor
    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    e6a4735 View commit details
    Browse the repository at this point in the history

  41. res/controllers: Remove global color constant from .eslint.json

    @Holzhaus
    Holzhaus committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    5b846c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2020

  1. res/controllers/midi-components: Remove references to global color ob… 

    …ject
    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    52062f3 View commit details
    Browse the repository at this point in the history

  2. test/controllerengine_test: Remove test for ColorJSProxy

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    6181401 View commit details
    Browse the repository at this point in the history

  3. cuecontrol: Remove unnecessary instantiation of ColorPaletteSettings

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    dc9e476 View commit details
    Browse the repository at this point in the history

  4. track/cue: Remove misleading alpha channel

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    fcf2401 View commit details
    Browse the repository at this point in the history

  5. util/color/colorpalette: Enclose color consts in anonymous namespace

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    b8ee8d6 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary const from (optional) RgbColor parameters

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    26f8c3b View commit details
    Browse the repository at this point in the history

  7. engine/controls/cuecontrol: Use emit without braces

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    a0379dc View commit details
    Browse the repository at this point in the history

  8. library/dao/cuedao: Replace static_cast with RgbColor::toQVariant

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    dd353e6 View commit details
    Browse the repository at this point in the history

  9. engine/controls/cuecontrol: Clean up auto_hotcue_colors logic

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    328edfb View commit details
    Browse the repository at this point in the history

  10. engine/controls/cuecontrol: Improve HotcueControl::setColor code

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    bb2f30b View commit details
    Browse the repository at this point in the history

  11. engine/controls/cuecontrol: Use kNoColorControlValue const instead of -1

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    129e0e6 View commit details
    Browse the repository at this point in the history

  12. preferences/colorpalettesettings: Do not access m_colorList directly

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    7022535 View commit details
    Browse the repository at this point in the history

  13. util/color/colorpalette: Make sure that ColorPalette has at least 1 c… 

    …olor
    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    35e2e79 View commit details
    Browse the repository at this point in the history

  14. util/color/colorpalette: Make m_colorList private

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    8060f91 View commit details
    Browse the repository at this point in the history

  15. util/color/colorpalette: Add nextColor/previousColor methods

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    d7557ad View commit details
    Browse the repository at this point in the history

  16. test/colorpalette_test: Add tests for ColorPalette methods

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    9d1cbf4 View commit details
    Browse the repository at this point in the history

  17. library/dao/cuedao: Use RgbColor::fromQVariant in cueFromRow method

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    b648a5d View commit details
    Browse the repository at this point in the history

  18. Make all single argument constructors explicit

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    c8ad295 View commit details
    Browse the repository at this point in the history

  19. library/dlgtrackinfo: Swap DlgTrackInfo constructor arguments

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    6841da6 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'master' of github.com:mixxxdj/mixxx into hotcue-rgb-colors

    @Holzhaus
    Holzhaus committed Mar 1, 2020
    Configuration menu
    Copy the full SHA
    8d36723 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. Merge branch 'master' of github.com:mixxxdj/mixxx into hotcue-rgb-colors

    @Holzhaus
    Holzhaus committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    fa6dba8 View commit details
    Browse the repository at this point in the history

  2. controllers/colormapper: Use static_casts instead of C-style casts

    @Holzhaus
    Holzhaus committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    4180310 View commit details
    Browse the repository at this point in the history

  3. engine/controls/cuecontrol: Use auto to avoid repeating type names

    @Holzhaus
    Holzhaus committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    1ef5084 View commit details
    Browse the repository at this point in the history

  4. preferences/colorpalettesettings: Move group constans into anon names… 

    …pace
    @Holzhaus
    Holzhaus committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    43cbedb View commit details
    Browse the repository at this point in the history

  5. util/color/colorpalette: Simplify ColorPalette::previousColor modulo … 

    …logic
    @Holzhaus
    Holzhaus committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    287855a View commit details
    Browse the repository at this point in the history

  6. widget/wcolorpicker: Avoid negation in if (expr) { } else { } conditions

    @Holzhaus
    Holzhaus committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    0621d0a View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. Add support for multiple named color palettes

    @Holzhaus
    Holzhaus committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    3f94fd6 View commit details
    Browse the repository at this point in the history

  2. widget/wcolorpicker: Add support for switching palettes with differen… 

    …t sizes
    @Holzhaus
    Holzhaus committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5b4c695 View commit details
    Browse the repository at this point in the history

  3. wcolorpickeraction: Use current track color palette when opening menu

    @Holzhaus
    Holzhaus committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    4bc091e View commit details
    Browse the repository at this point in the history

  4. widget/wcuemenupopup: Use current hotcue color palette when menu is s… 

    …hown
    @Holzhaus
    Holzhaus committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    dcec320 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. res/schema.xml: Fix comment of hotcue color migration (s/RGBA/RGB/)

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    80eb2ba View commit details
    Browse the repository at this point in the history

  2. controllers/colormapper: Do not inherit from QObject

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    9b68234 View commit details
    Browse the repository at this point in the history

  3. engine/controls/cuecontrol: Remove superfluous comment

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    df02dec View commit details
    Browse the repository at this point in the history

  4. preferences/colorpalettesettings: Use constant for fallback color

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    c4be500 View commit details
    Browse the repository at this point in the history

  5. preferences/configobject: Remove key if color value is not set

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    448d1b7 View commit details
    Browse the repository at this point in the history

  6. util/color/colorpalette: Make class final

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    f1ac5de View commit details
    Browse the repository at this point in the history

  7. widget/wcolorpicker: Swap order of captured lambda variables

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    8b222ff View commit details
    Browse the repository at this point in the history

  8. track/cue: Reuse default cue color constant from ColorPalette

    @Holzhaus
    Holzhaus committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    c52f8b3 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. res/schema.xml: Remove useless alpha channel

    @Holzhaus
    Holzhaus committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    9e0c651 View commit details
    Browse the repository at this point in the history

  2. util/color/colorpalette: Use shorter initialization for color constexprs

    @Holzhaus
    Holzhaus committed Mar 6, 2020
    1 Configuration menu
    Copy the full SHA
    abea669 View commit details
    Browse the repository at this point in the history

  3. preferences/colorpalettesettings: Fix order of palettes with >=10 colors

    @Holzhaus
    Holzhaus committed Mar 6, 2020
    1 Configuration menu
    Copy the full SHA
    67af302 View commit details
    Browse the repository at this point in the history

  4. util/color/colorpalette: Add colorForHotcueIndex method

    @Holzhaus
    Holzhaus committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    ef8e535 View commit details
    Browse the repository at this point in the history

  5. engine/controls/cuecontrol: Use default color if auto_hotcue_colors i… 

    …s off
    @Holzhaus
    Holzhaus committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    fbcea0b View commit details
    Browse the repository at this point in the history

  6. Use orange (not in palette) for "no color" schema migration and new cues

    @Holzhaus
    Holzhaus committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    5cda96d View commit details
    Browse the repository at this point in the history

  7. Roland DJ-505: Remove unnecessary alpha channel from ColorMapper

    @Holzhaus
    Holzhaus committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    e719af5 View commit details
    Browse the repository at this point in the history

  8. preferences/colorpalettesettings: Replace maxDigits with numDigits

    @Holzhaus
    Holzhaus committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    74e6cf7 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. Use #FF8C00 instead of #FF8000 as "no color" replacement 

    Color taken from:
mixxxdj#2031 (comment)
    @Holzhaus
    Holzhaus committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    078e595 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. engine/controls/cuecontrol: Remove commented lines

    @Holzhaus
    Holzhaus committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    43fc59d View commit details
    Browse the repository at this point in the history

  2. controllers/colormapper: Improve constructor and remove destructor

    @Holzhaus
    Holzhaus committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    ee5e5e4 View commit details
    Browse the repository at this point in the history

  3. controllers/colormapperjsproxy: Add small code style improvements

    @Holzhaus
    Holzhaus committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    7fe6f81 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. res/schema.xml: Add comment regarding hotcue palette to schema

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    0a423a0 View commit details
    Browse the repository at this point in the history

  2. controllers/colormapper: Replace qDebug() with kLogger.trace()

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ba01c5f View commit details
    Browse the repository at this point in the history

  3. Add/improve comments for new classes and free functions

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    9883318 View commit details
    Browse the repository at this point in the history

  4. controllers/colormapperjsproxy: Use auto instead of long type name

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3c0a3fe View commit details
    Browse the repository at this point in the history

  5. controllers: Use const refs instead of const-by-value for HID/HSS1394

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    b4e9de9 View commit details
    Browse the repository at this point in the history

  6. controllers/controllerengine: Declare immutable m_pConfig member as c… 

    …onst
    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    90b1109 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of github.com:mixxxdj/mixxx into hotcue-rgb-colors

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    20ce76f View commit details
    Browse the repository at this point in the history

  8. controllers/colormapperjsproxy: Use script errors instead of assertions

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    8ca8003 View commit details
    Browse the repository at this point in the history

  9. controllers/colormapperjsproxy: Add comment to slots with return value

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    6eb2124 View commit details
    Browse the repository at this point in the history

  10. util/color/colorpalette: Fix swapped green/blue hotcue palette colors

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    be415ba View commit details
    Browse the repository at this point in the history

  11. test/colormapperjsproxy_test: Add tests for ColorMapperJSProxy

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    eb2fd28 View commit details
    Browse the repository at this point in the history

  12. controllers/colormapperjsproxy: Use Q_INVOKABLE instead of slots

    @Holzhaus
    Holzhaus committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    6046abf View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. res/controllers/common-controller-scripts.js: Fix eslint errors

    @Holzhaus
    Holzhaus committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    a538a09 View commit details
    Browse the repository at this point in the history

  2. res/controllers: Add color conv. functions to common-controller-scripts

    @Holzhaus
    Holzhaus committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    702050f View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. res/controllers/common-controller-scripts.js: Break long lines

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    e859c7d View commit details
    Browse the repository at this point in the history

  2. controllers/colormapper: Split function to avoid using QPair

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    42f82a3 View commit details
    Browse the repository at this point in the history

  3. controllers/bulk/bulkenumerator: Use one initialization per line

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9e9a56f View commit details
    Browse the repository at this point in the history

  4. controllers/colormapperjsproxy: Add comments that explain the invokab… 

    …le methods
    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    2a0608b View commit details
    Browse the repository at this point in the history

  5. controllers/colormapperjsproxy: Rename getNearestValue to getValueFor… 

    …NearestColor
    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    a48afde View commit details
    Browse the repository at this point in the history

  6. res/controllers/common-controller-scripts: Document color conv. funct… 

    …ions
    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    05012ec View commit details
    Browse the repository at this point in the history

  7. res/controllers/midi-components-0.0.js: Add range change to outputCol… 

    …or()
    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    f3a954e View commit details
    Browse the repository at this point in the history

  8. res/controllers/midi-components-0.0.js: Throw error if sendRGB is und… 

    …efined
    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    2f95d2d View commit details
    Browse the repository at this point in the history

  9. res/controllers/midi-components-0.0.js: Add some more comments

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    f50ccbe View commit details
    Browse the repository at this point in the history

  10. res/controllers/midi-components-0.0.js: Add HotcueButton.sendRGB func… 

    …tion stub
    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    44b8237 View commit details
    Browse the repository at this point in the history

  11. preferences/colorpalettesettings: Remove leftover qWarning() statement

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    abd663f View commit details
    Browse the repository at this point in the history

  12. test/colorconfig_test: Use literal names for LoadSavePalettes tests

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    1 Configuration menu
    Copy the full SHA
    e7a3553 View commit details
    Browse the repository at this point in the history

  13. test/colormapperjsproxy_test: Use raw c++ string literals for JS code

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    1 Configuration menu
    Copy the full SHA
    ec11d6b View commit details
    Browse the repository at this point in the history

  14. util/color/colorpalette: Return last color if color not in palette

    @Holzhaus
    Holzhaus committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    714f446 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. controllers/colormapper: Simplify and speed up code in getNearestColor

    @Holzhaus
    Holzhaus committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    8dca9a6 View commit details
    Browse the repository at this point in the history

  2. controllers/midi-components: Change comment wording in output()

    @Holzhaus
    Holzhaus committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    9130b80 View commit details
    Browse the repository at this point in the history

  3. controllers/midi-components: Print invalid colorCodes

    @Holzhaus
    Holzhaus committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    4a79af3 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Merge branch 'master' of github.com:mixxxdj/mixxx into hotcue-rgb-colors

    @Holzhaus
    Holzhaus committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    7cc0444 View commit details
    Browse the repository at this point in the history

  2. engine/controls/cuecontrol: Prevent segfaults in slotHotcueColorChanged

    @Holzhaus
    Holzhaus committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    92df887 View commit details
    Browse the repository at this point in the history

  3. widget/wcolorpicker: Simplify (re-)setSelectedColor logic

    @Holzhaus
    Holzhaus committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    be48247 View commit details
    Browse the repository at this point in the history

  4. widget/wwidget: Early exit for error case in getBackgroundColorRgba()

    @Holzhaus
    Holzhaus committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    b4855e0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:mixxxdj/mixxx into hotcue-rgb-colors

    @Holzhaus
    Holzhaus committed Mar 13, 2020
    Configuration menu
    Copy the full SHA
    9712d26 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2020

  1. preferences/colorpalettesettings: Use QStringLiteral for regex

    @Holzhaus
    Holzhaus committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    4e943f8 View commit details
    Browse the repository at this point in the history

  2. preferences/colorpalettesettings: Use StringBuilder for group names

    @Holzhaus
    Holzhaus committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    0e18f19 View commit details
    Browse the repository at this point in the history

  3. preferences/colorpalettesettings: Prevent setting empty color palettes

    @Holzhaus
    Holzhaus committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    dac09b2 View commit details
    Browse the repository at this point in the history

  4. widget/wcolorpicker: Use const int for remainder

    @Holzhaus
    Holzhaus committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    6499025 View commit details
    Browse the repository at this point in the history

  5. widget/wcolorpicker: Do not use else if after break

    @Holzhaus
    Holzhaus committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    5380904 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' of github.com:mixxxdj/mixxx into hotcue-rgb-colors

    @Holzhaus
    Holzhaus committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    233e99f View commit details
    Browse the repository at this point in the history

  7. library/dao/cuedao: Fix loading of cue colors from DB 

    As reported by @ywwg, all cues become black when they are loaded from
the database. Investigation shows that the color is always 7 (the column
index) instead of the actual value.
    @Holzhaus
    Holzhaus committed Mar 14, 2020
    Configuration menu
    Copy the full SHA
    c0fd0b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2020

  1. preferences/configobject: Make getKeysWithGroup() const

    @Holzhaus
    Holzhaus committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    96ca1d2 View commit details
    Browse the repository at this point in the history

  2. preferences/colorpalettesettings: Make some methods const

    @Holzhaus
    Holzhaus committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    827f6a0 View commit details
    Browse the repository at this point in the history

  3. preferences/colorpalettesettings: Move keyForIndex into anon namespace

    @Holzhaus
    Holzhaus committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    e18f8d5 View commit details
    Browse the repository at this point in the history

  4. res/schema.xml: Fix cue colors from previous schema migrations

    @Holzhaus
    Holzhaus committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    243fb32 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. res/controllers/midi-components: Add check for CO values > 0xFFFFFF

    @Holzhaus
    Holzhaus committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    4944594 View commit details
    Browse the repository at this point in the history