Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing nullptr checks (pt. 2) #2528

Merged
merged 1 commit into from Mar 1, 2020
Merged

Add missing nullptr checks (pt. 2) #2528

merged 1 commit into from Mar 1, 2020

Conversation

uklotzde
Copy link
Contributor

Completes #2527 for master.

@uklotzde uklotzde added this to the 2.3.0 milestone Feb 29, 2020
@uklotzde uklotzde changed the title Fix missing null pointer check (pt. 2) Add missing nullptr checks (pt. 2) Feb 29, 2020
Holzhaus
Holzhaus reviewed Feb 29, 2020
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, waiting for CI builds.

@Holzhaus
Copy link
Member

Holzhaus commented Mar 1, 2020

CI builds work, and I also built this locally, ran the tests and started mixxx. Everything works, thanks!

@Holzhaus Holzhaus merged commit 4ffe4ea into mixxxdj:master Mar 1, 2020
@uklotzde uklotzde deleted the wtracktableview branch March 1, 2020 23:16
@Holzhaus Holzhaus added this to Done in 2.3 release Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus left review comments

Assignees
No one assigned
Labels
critical bug
Projects
2.3 release
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uklotzde @Holzhaus