New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug #1316303 #257

Merged

daschuer merged 2 commits into mixxxdj:master from badescunicu:song_title_1316303

May 12, 2014

Contributor

badescunicu commented May 10, 2014

Parse the Artist and the Title from the file name when the corresponding ID3 tags are missing.

https://bugs.launchpad.net/mixxx/+bug/1316303


          Parse the Artist and the Title of a song from the filename if the cor…

58e79ec

…responding ID3 tags are empty

daschuer reviewed

View reviewed changes

src/trackinfoobject.cpp

+                  QString filename = m_fileInfo.fileName();
+                  if (filename.count('-') == 1) {
+                      m_sArtist = filename.section('-', 0, 0).trimmed();
+                      m_sArtist = m_sArtist.replace("_", " ");

Member

daschuer May 10, 2014

If you do this before trimming, we can handle Artist_-_Title.mp3 as well.


          Use parseArtist() and parseTitle() inside parseFilename()

a51ded8

Contributor Author

badescunicu commented May 12, 2014

Is there anything else I should do for this?

Member

daschuer commented May 12, 2014

LGTM! Thank you very much!

daschuer added a commit that referenced this pull request


          Merge pull request #257 from badescunicu/song_title_1316303

d4fd892

Bug #1316303

daschuer merged commit d4fd892 into mixxxdj:master

esbrandt added a commit to mixxxdj/manual that referenced this pull request


          Parse the title and the artist from the file name when the correspond…

07e745d

…ing metadata are missing, see mixxxdj/mixxx#257

mixxxbot mentioned this pull request

Mixxx does not display the song title if the ID3 tag is not present #7460

Closed

m0dB pushed a commit to m0dB/mixxx that referenced this pull request


          2.3.1 release announcement (mixxxdj#257)

4b7d6ea

Co-authored-by: ronso0 <ronso0@mixxx.org>
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
Co-authored-by: Be <be.0@gmx.com>
Co-authored-by: Swiftb0y <12380386+Swiftb0y@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment