Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Controller Script Error Reporting #2588

Merged
merged 22 commits into from Apr 18, 2020
Merged

Improve Controller Script Error Reporting #2588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a07164d
controllers/controllerengine: Improve error messages for mappings
Holzhaus Mar 22, 2020
fe4aae2
controllers/controllerengine: Enable errors popups in all cases
Holzhaus Mar 22, 2020
0b55805
controllers/controllerengine: Add missing nullptr checks
Holzhaus Mar 22, 2020
3bf5b0b
controllers/controllerengine: Move uninitialize engine code into method
Holzhaus Mar 22, 2020
2bc6e89
controllers/controllerengine: Uninitalize if script load failed
Holzhaus Mar 22, 2020
c64a0e1
Merge branch 'master' of github.com:mixxxdj/mixxx into script-error-r…
Holzhaus Apr 11, 2020
f82fcc8
controllers/controllerengine: Remove duplicated code and fix popup logic
Holzhaus Apr 11, 2020
1d6d81e
controllers/controllerengine: Always show the backtrace on script errors
Holzhaus Apr 11, 2020
5ad0f27
controllers/controllerengine: Fix error message text
Holzhaus Apr 12, 2020
712ced4
controllers/controllerengine: Further improve error dialog details
Holzhaus Apr 12, 2020
0e29507
controllers/controllerengine: Use monospace font for script error det…
Holzhaus Apr 12, 2020
a4fde4f
controllers/controllerengine: Fix wrong debug assertion
Holzhaus Apr 16, 2020
456f8ab
controllers/controllerengine: Remove unusued getErrors method
Holzhaus Apr 16, 2020
e1abe15
controllers/controllerengine: Clear script errors upon reinitialization
Holzhaus Apr 16, 2020
cee2458
controllers/controllerengine: Make errors during script init fatal
Holzhaus Apr 16, 2020
c8d96a3
controllers/controllerengine: Removed unused initialized signal
Holzhaus Apr 16, 2020
961d9a0
controllers/controllerengine: Do not translate script error messages
Holzhaus Apr 16, 2020
7c0d692
controllers/controllerengine: Improve file open error message
Holzhaus Apr 16, 2020
0d1cf7f
controllers/controllerengine: Stop engine if controller init fails
Holzhaus Apr 16, 2020
1a15898
controllers/controllerengine: Improve syntax check error message
Holzhaus Apr 16, 2020
c9a5ca5
controllers/controllerengine: Use key without backtrace for "ignore e…
Holzhaus Apr 16, 2020
1d3f91c
controllers/controllerengine: Use debug assert in callFunctionOnObjects
Holzhaus Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/controllers/controller.cpp
View file
Open in desktop
Expand Up @@ -68,7 +68,7 @@ bool Controller::applyPreset(bool initializeScripts) {
}

bool success = m_pEngine->loadScriptFiles(scriptFiles);
if (initializeScripts) {
if (success && initializeScripts) {
m_pEngine->initializeScripts(scriptFiles);
}
return success;
Expand Down