Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lp1864512 : Preferences DialogBox: LeftNavbar Pane width made adjustable #2595

Merged
merged 2 commits into from Mar 25, 2020
Merged

lp1864512 : Preferences DialogBox: LeftNavbar Pane width made adjustable #2595

merged 2 commits into from Mar 25, 2020

Conversation

ketan-lambat
Copy link
Contributor

@ketan-lambat ketan-lambat commented Mar 23, 2020 •
edited

@Holzhaus Holzhaus added the ui label Mar 23, 2020
Holzhaus
Holzhaus approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@Holzhaus Holzhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this, looks good to me and works nicely.

@Holzhaus
Copy link
Member

@rons0 You want to take a look or can I merge?

@Holzhaus Holzhaus requested a review from ronso0 March 25, 2020 14:12
@ronso0
Copy link
Member

ronso0 commented Mar 25, 2020

LGTM especially that the splitsizes are restored when opening the Prefs again during a session.
👍

@Holzhaus Holzhaus merged commit 78a6474 into mixxxdj:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Holzhaus Holzhaus Holzhaus approved these changes

@ronso0 ronso0 Awaiting requested review from ronso0

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ketan-lambat @Holzhaus @ronso0