Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GUI states of Library feature buttons #2628

Merged
merged 14 commits into from
Apr 15, 2020
Merged

fix GUI states of Library feature buttons #2628

merged 14 commits into from
Apr 15, 2020

Commits on Apr 4, 2020

  1. make Anylysis button checkable, unchecked by default

    @ronso0
    ronso0 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    8206d07 View commit details
    Browse the repository at this point in the history

  2. DlgAutoDJ: use clicked() signal for all QPushButtons 

    This prevents inifit loop issues when real click events and
programmatic QPushButton::setChecked() calls conflict:
* clicked(bool checked) is only emitted on mouse clicks
* toggled(bool checked) is emitted both on mouse clicks and setChecked() calls
    @ronso0
    ronso0 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    7b8d74b View commit details
    Browse the repository at this point in the history

  3. DlgRecording: use QPushButton::clicked() signal instead of toggled()

    @ronso0
    ronso0 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    6035a24 View commit details
    Browse the repository at this point in the history

  4. DlgRecording: separate Rec toggle & button update 

    Redirect toggle request to RecordingManager::slotToggleRecording()
and let slotRecordingEnabled() handle the button update.
    @ronso0
    ronso0 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    db17fd1 View commit details
    Browse the repository at this point in the history

  5. DlgRecording: use unambiguous slot names

    @ronso0
    ronso0 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    2e66652 View commit details
    Browse the repository at this point in the history

  6. recordingmanager.cpp: apply new signal/sot syntax

    @ronso0
    ronso0 committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    6be0ef8 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. RecordingManager::slotToggleRecording: revert to 'double' input

    @ronso0
    ronso0 committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    da58d82 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. re-sync recording state and GUI after (re)loading a skin

    @ronso0
    ronso0 committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    04e43e1 View commit details
    Browse the repository at this point in the history

  2. Recording: split up info labels, add skin styles

    @ronso0
    ronso0 committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    e14a3d8 View commit details
    Browse the repository at this point in the history

  3. delay loading Analysis table until it's shown 

    According to the removed ToDo, doing this at feature init would
extend the skin loading time.
    @ronso0
    ronso0 committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    4030dbd View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. dlgrecording.cpp: move the parentheses out of the translation string 

    Co-Authored-By: Jan Holthuis <holthuis.jan@googlemail.com>
    @ronso0 @Holzhaus
    ronso0 and Holzhaus committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    4abb53d View commit details
    Browse the repository at this point in the history

  2. dlgrecording.cpp: remove double parantheses 

    Co-Authored-By: Jan Holthuis <holthuis.jan@googlemail.com>
    @ronso0 @Holzhaus
    ronso0 and Holzhaus committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    0c8bfff View commit details
    Browse the repository at this point in the history

  3. dlgrecording.cpp: remove double parantheses 

    Co-Authored-By: Jan Holthuis <holthuis.jan@googlemail.com>
    @ronso0 @Holzhaus
    ronso0 and Holzhaus committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    022d060 View commit details
    Browse the repository at this point in the history

  4. DlgRecording: fix recording label string construction

    @ronso0
    ronso0 committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    5599cd3 View commit details
    Browse the repository at this point in the history