Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add track color control object #2665

Merged
merged 4 commits into from Apr 15, 2020
Merged

Add track color control object #2665

merged 4 commits into from Apr 15, 2020

Conversation

Holzhaus
Copy link
Member

No description provided.

daschuer
daschuer requested changes Apr 14, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already good, what is missing?
Very similar to my draft branch I have here.

src/mixer/basetrackplayer.cpp Outdated Show resolved Hide resolved
@Holzhaus Holzhaus mentioned this pull request Apr 14, 2020
Merged
@Holzhaus
Copy link
Member Author

Looks already good, what is missing?
Very similar to my draft branch I have here.

For some reason the new color isn't always applied to the track in the track table. I have to investigate.

uklotzde
uklotzde reviewed Apr 15, 2020
View reviewed changes
src/mixer/basetrackplayer.cpp Outdated Show resolved Hide resolved
src/track/track.h Outdated Show resolved Hide resolved
@Holzhaus Holzhaus marked this pull request as ready for review April 15, 2020 08:48
@Holzhaus
Copy link
Member Author

Ok, I think this PR is ready now.

@Holzhaus Holzhaus added this to the 2.3.0 milestone Apr 15, 2020
@Holzhaus Holzhaus added this to In progress in 2.3 release via automation Apr 15, 2020
@Holzhaus Holzhaus moved this from In progress to In Review in 2.3 release Apr 15, 2020
@Holzhaus Holzhaus marked this pull request as draft April 15, 2020 12:46
@Holzhaus Holzhaus marked this pull request as ready for review April 15, 2020 13:19
@Holzhaus Holzhaus requested a review from daschuer April 15, 2020 13:19
@daschuer
Copy link
Member

LGTM, @uklotzde: merge?

@uklotzde uklotzde merged commit d72575d into mixxxdj:master Apr 15, 2020
2.3 release automation moved this from In Review to Done Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde left review comments

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
library
Projects
2.3 release
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Holzhaus @daschuer @uklotzde