Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WTrackMenu: Cleanup & performance regression fixes (part 2) #2684

Merged
merged 22 commits into from
Apr 21, 2020
Merged

WTrackMenu: Cleanup & performance regression fixes (part 2) #2684

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
162b9a5
Do NOT load tracks while collecting indices for TrackModel
uklotzde Apr 18, 2020
111b56e
Separate different uses cases in WTrackMenu
uklotzde Apr 18, 2020
0f7f95c
Remove redundant checks, remove temporary variables, streamline loops
uklotzde Apr 18, 2020
4289737
Add a fast check for empty selections, avoid loading tracks
uklotzde Apr 18, 2020
f07b73f
Only load the minimum number of tracks
uklotzde Apr 18, 2020
4e0a23c
Avoid loading unused tracks
uklotzde Apr 18, 2020
c26e23d
Clean up and fix WTrackMenu::updateMenus()
uklotzde Apr 18, 2020
204d3f0
Check for emptiness upfront
uklotzde Apr 19, 2020
978a52a
Extract special case from conditional expression
uklotzde Apr 19, 2020
0a0553a
Replace if/else-if cascade with switch statement
uklotzde Apr 19, 2020
eafc895
Handle all enum literals in switch statement
uklotzde Apr 19, 2020
a7bab95
Fix unused variable warning
uklotzde Apr 19, 2020
57447bd
Handle empty selection in WTrackMenu::updateMenus()
uklotzde Apr 19, 2020
0499b00
Fix update of BPM context menu
uklotzde Apr 19, 2020
c543685
Fix update of cover art context menu
uklotzde Apr 19, 2020
9a5f5a0
Fix update of Reset context menu
uklotzde Apr 19, 2020
a289454
Fix update of track color context menu
uklotzde Apr 19, 2020
d6025f8
Extract utility functions from WTrackMenu::updateMenus()
uklotzde Apr 20, 2020
8fbbdab
Merge branch 'master' into wtrackmenu_cleanup
uklotzde Apr 20, 2020
529fd9f
Add a debug assertion to emphasize the use case
uklotzde Apr 20, 2020
a1591de
Join and reformat lines
uklotzde Apr 21, 2020
bcf4de6
Add reset action to "Adjust BPM" menu
uklotzde Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view