make mic ducking use strength the same way in Auto & Man mode #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My manual tests went well but the engine tests are failing. |
daschuer
approved these changes
May 5, 2020
daschuer
requested changes
May 5, 2020
| // If we overshot, clamp. | ||
| m_compressRatio = 0; | ||
| m_compressRatio = 1; | ||
| } | ||
| } else if (m_compressRatio < 0) { | ||
| // Complain loudly. | ||
| qWarning() << "Programming error, below-zero compression detected."; |
There was a problem hiding this comment.
VERIFY_OR_DEBUG_ASSERT and before the condition above.
There was a problem hiding this comment.
Hopefully I got your suggestion right here
} else {
VERIFY_OR_DEBUG_ASSERT(m_compressRatio >= 0) {
qWarning() << "Programming error, below-zero compression detected.";
}
if (m_compressRatio < 1) {
m_compressRatio += m_decayPerFrame * frames;
if (m_compressRatio > 1) {
// If we overshot, clamp.
m_compressRatio = 1;
}
}
}
(sorry, I force-pushed)
There was a problem hiding this comment.
local engine tests are all passing now.
Previously, engine/enginetalkoverducking returned opposite values
for 'strength' in Auto and Manual mode. This commit removes the
inversion from Auto mode, thus the Strength knob always affects the
music volume in the same way with both modes, much like a Muisc Volume
knob: * fully left: music muted completely
* fully right: music volume unchanged
ronso0
force-pushed
the
mic-ducking-strength
branch
from
689395d
to
6232a33
Compare
daschuer
approved these changes
May 6, 2020
|
LGTM, Thank you. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, engine/enginetalkoverducking returned opposite gain values for 'strength' in Auto and Manual mode.
This commit removes the inversion from Auto mode, thus the Strength knob is like a Music volume knob with both modes now, nicely illustrated with reversed knob arc:
