Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controllers/midi/midicontroller: Ignore MIDI clock messages (0xF8) #2786

Merged
merged 2 commits into from May 13, 2020
Merged

controllers/midi/midicontroller: Ignore MIDI clock messages (0xF8) #2786

merged 2 commits into from May 13, 2020

Conversation

Holzhaus
Copy link
Member

Very small bugfix for MIDI beat clock capable controllers that inhibited the screensaver unintentionally. Nice side effect that this also makes --controllerDebug actually usable for me.

@Holzhaus Holzhaus added this to the 2.3.0 milestone May 13, 2020
@Holzhaus Holzhaus added this to In progress in 2.3 release via automation May 13, 2020
@Holzhaus
Copy link
Member Author

Or should this go into the 2.2 branch?

@uklotzde uklotzde changed the base branch from 2.3 to 2.2 May 13, 2020 14:29
@uklotzde uklotzde changed the base branch from 2.2 to 2.3 May 13, 2020 14:30
@uklotzde
Copy link
Contributor

2.2 sounds reasonable, please rebase. We should add a changelog entry.

@Holzhaus Holzhaus changed the base branch from 2.3 to 2.2 May 13, 2020 14:54
@uklotzde uklotzde modified the milestones: 2.3.0, 2.2.4 May 13, 2020
@uklotzde uklotzde removed this from In progress in 2.3 release May 13, 2020
@uklotzde
Copy link
Contributor

LGTM

@uklotzde uklotzde merged commit 6034875 into mixxxdj:2.2 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
controller mappings minor bug
Projects
None yet
Milestone
2.2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Holzhaus @uklotzde