Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use tempdir for broadcast profiles #2976

Merged
merged 1 commit into from
Aug 5, 2020
Merged

test: Use tempdir for broadcast profiles #2976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions src/test/broadcastprofile_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,40 +42,39 @@ TEST(BroadcastProfileTest, SaveAndLoadXML) {
// Preliminary: set a discriminating value in one of the profile fields
QString streamName("unit testing in progress");

BroadcastProfile profile("Unit Testing Profile");
BroadcastProfile profile("Broadcast Profile test");
profile.setStreamName(streamName);

QString filename = profile.getProfileName() + QString(".bcp.xml");
QTemporaryDir tempDir;
ASSERT_TRUE(tempDir.isValid());
QString filename = tempDir.filePath(profile.getProfileName() + QString(".bcp.xml"));

// Call save() on a profile and assert it actually exists
QFile::remove(filename); // First, make sure it doesn't exists
profile.save(filename);
ASSERT_TRUE(QFile::exists(filename));

// Load XML file using static loadFromFile and assert
// the discriminating value is present
BroadcastProfilePtr savedProfile = BroadcastProfile::loadFromFile(filename);
ASSERT_NE(savedProfile, nullptr);
ASSERT_TRUE(savedProfile->getStreamName() == streamName);
EXPECT_NE(savedProfile, nullptr);
EXPECT_TRUE(savedProfile->getStreamName() == streamName);
xeruf marked this conversation as resolved.
Show resolved Hide resolved
}

TEST(BroadcastProfileTest, SaveAndLoadXMLDotName) {
QString profileName("profile has a dot. (in the name)");

QString profileName("broadcast profile has a dot. (in the name) test");
BroadcastProfile profile(profileName);

QString filename = profile.getProfileName() + QString(".bcp.xml");
QTemporaryDir tempDir;
ASSERT_TRUE(tempDir.isValid());
QString filename = tempDir.filePath(profile.getProfileName() + QString(".bcp.xml"));

// Call save() on a profile and assert it actually exists
QFile::remove(filename); // First, make sure it doesn't exists
profile.save(filename);
ASSERT_TRUE(QFile::exists(filename));

// Load XML file using static loadFromFile and assert
// the discriminating value is present
BroadcastProfilePtr savedProfile = BroadcastProfile::loadFromFile(filename);
ASSERT_NE(savedProfile, nullptr);
ASSERT_TRUE(savedProfile->getProfileName() == profileName);
EXPECT_NE(savedProfile, nullptr);
EXPECT_TRUE(savedProfile->getProfileName() == profileName);
}

TEST(BroadcastProfileTest, SetGetValues) {
Expand Down