lp1890116: Fix import of external playlists #3017
Conversation
|
Could someone please review this PR? It just reverts to the previous, string-formatting approach with some minor code improvements.
|
| QSqlQuery query(m_database); | ||
| FieldEscaper f(m_database); | ||
| QString queryString = | ||
| const auto playlistIdNumber = |
There was a problem hiding this comment.
Personally, I think using auto instead of QString only saves 2 chars and makes it less apparent which type we're dealing with.
There was a problem hiding this comment.
Arguing about individual cases is the wrong approach. The length of 'QString' should not matter, it could be any type. The usage of auto must not depend on how many characters it saves.
More appropriate rule: auto is allowed if the resulting type is immediately apparent from the right-hand-side expression.
There was a problem hiding this comment.
In this case, it reduces redundancy, which is worth more than saving 2 characters ;)
https://bugs.launchpad.net/mixxx/+bug/1890116
Broken by 085af01
Affects all external playlist views, not only iTunes!
bindValue()does not seem to work forCREATE TEMPORARY VIEW.