Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppVeyor: do not post Zulip notifications for PR builds #3041

Merged
merged 1 commit into from
Aug 23, 2020
Merged

AppVeyor: do not post Zulip notifications for PR builds #3041

merged 1 commit into from
Aug 23, 2020

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 23, 2020

These are more annoying than useful.

DO NOT MERGE BEFORE APPVEYOR BUILDS THIS BRANCH.

@Be-ing
AppVeyor: do not post Zulip notifications for PR builds
c81584b 
These are more annoying than useful.
@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 23, 2020

AppVeyor build completed and there was no post to Zulip. 👍

@Holzhaus
Copy link
Member

Merge?

@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 23, 2020

IMO this is ready to merge.

@Holzhaus Holzhaus merged commit ae7d79b into mixxxdj:master Aug 23, 2020
@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 23, 2020

Whoops, I intended to target this for the 2.3 branch. I cherry-picked it: 5d3e91e

@Be-ing Be-ing deleted the appveyor_no_pr_notifications branch August 23, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Be-ing @Holzhaus