Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine/loopingcontrol: Fix precision loss (wrong use of int) #3126

Merged
merged 2 commits into from Sep 26, 2020
Merged

engine/loopingcontrol: Fix precision loss (wrong use of int) #3126

merged 2 commits into from Sep 26, 2020

Conversation

Holzhaus
Copy link
Member

Found thanks to -Wfloat-conversion. There is no comment that indicates that this loss of precision is intended, so I think this is a bug.

@Holzhaus Holzhaus added this to the 2.2.5 milestone Sep 25, 2020
@Holzhaus Holzhaus mentioned this pull request Sep 25, 2020
Merged
11 tasks
daschuer
daschuer approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you.

@daschuer
Copy link
Member

Can you also add a line into CHANGELOG?

@Holzhaus
Copy link
Member Author

Can you also add a line into CHANGELOG?

Done.

daschuer
daschuer approved these changes Sep 26, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@daschuer daschuer merged commit 7ad9de3 into mixxxdj:2.2 Sep 26, 2020
@uklotzde uklotzde modified the milestones: 2.2.5, 2.3.0 May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
code quality minor bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Holzhaus @daschuer @uklotzde