librarycontrol.cpp: fix slotGotToItem in tracks table #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Appearantly m_pLibraryWidget->hasFocus() always returns false. Instead check m_pLibraryWidget->getActiveView()->hasFocus()
|
Damn. This had to go to 2.3 first. |
daschuer
added a commit
to daschuer/mixxx
that referenced
this pull request
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed that
[Library],GoToItemdoens't work in the tracks table.Appearantly
m_pLibraryWidget->hasFocus()always returns false.Instead check
m_pLibraryWidget->getActiveView()->hasFocus()For testing without a controller trigger
[Library],GoToItemin developer tools and set TrackLoadAction to "Load to first stopped deck" to see result.