Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add [group],CloneFromSampler control #3200

Merged
merged 2 commits into from Oct 26, 2020
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 22, 2020

A simple addition to clone controls to be used in mappings:
[AnyPlayer], CloneFromSampler, int samplerNum

My use case:

  • store several next track candidates in samplers
  • clone tracks from samplers to decks (and vice versa if I notice a track would match better later on)

Will add this to the controls docu once it's merged.

Initially I tried to create a general ..,CloneFromGroup" control for use in mappings but failed fetching the group string...

@ronso0 ronso0 added this to In progress in 2.3 release via automation Oct 22, 2020
@ronso0 ronso0 moved this from In progress to In Review in 2.3 release Oct 22, 2020
@ronso0 ronso0 added this to the 2.3.0 milestone Oct 22, 2020
@daschuer
Copy link
Member

The pre-commit hock fails.

@Holzhaus @uklotzde
Today I am on my phone and I am not able to open the ... Menu because of my Wurstsfinger.
This really sucks ...

src/mixer/basetrackplayer.cpp Outdated Show resolved Hide resolved
src/mixer/basetrackplayer.cpp Outdated Show resolved Hide resolved
src/mixer/basetrackplayer.cpp Show resolved Hide resolved
@daschuer
Copy link
Member

The pre-commit hook still fails.

@ronso0
Copy link
Member Author

ronso0 commented Oct 22, 2020

eeehm, forgot to push..
Done.

@ronso0 ronso0 requested a review from daschuer October 26, 2020 01:22
@Be-ing Be-ing merged commit a2f1f52 into mixxxdj:2.3 Oct 26, 2020
2.3 release automation moved this from In Review to Done Oct 26, 2020
@Be-ing
Copy link
Contributor

Be-ing commented Oct 26, 2020

Good idea. Please add to the ControlObject documentation.

@ronso0 ronso0 deleted the cloneFromSapler branch October 27, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.3 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants