Searchbar clear

[poelzi]

Smaller updates to the searchbar.

Add pseudo entry to clear searchbar with up key:
https://mixxx.zulipchat.com/#narrow/stream/113295-controller-mapping/topic/Clear.20input.20of.20search.20bar

Fixes bug https://bugs.launchpad.net/bugs/1902597

[daschuer]

LGTM and works nicely. Thank you.

[ronso0]

I don't agree:
how do you quickly clear the search from a controller now?
Scrolling all the way to the top of the search history is no option for me.

I know this was requested on Zulip because someone uses a custom mappin for the Trax encoder press and wants to reduce the Tabs necessary to get to the tracks table, but the default most common mapping is [Library],GoToItem.

[poelzi]

The current system is also problematic for blind users as the tab order changes depending on the state of the search bar.

I'm ambivalent about the focus behaviour. What's the general stand towards this ?

[poelzi]

Since there was not much feedback and I don't care that much, I reverted the focus change and let the keyup clearing stay. Ready for merge.

[daschuer]

I have tested the behavior again and found that the whole history is cleared with the clear icon:
https://bugs.launchpad.net/mixxx/+bug/1913660
That is at least surprising.

Do we need the clear history feature? If yes, we may add a dummy entry at the very end.

This can be merged as it is IMHO.

@rons0: What do you think?

[ronso0]

Well, it works when applied to a search that is present already, index = 0
Else the index remains -1 until the savetimer expired (5000 ms) or Down is pressed (even if it's the only entry atm).

We should stop the saveTimer and clear the field in that case.
if (findCurrentTextIndex() == -1 && !currentText().isEmpty()) { m_saveTimer.stop(); ...
It would be consistent to save the term if the debouncing timer already expired (default is 300ms), but maybe we accumulate to much unused items in the combobox -- which might be an issue when scrolling through the search index list, until we have means to remove individual indices from the list.

[ronso0]

please check poelzi#4
it fixes the save timer issue, and also lp:1913660 Search bar clear button clears entire search history

[ronso0]

btw ping @poelzi

[ronso0]

actually ready to be merged, but now there's a small issue with the popup:

• populate the list with 1, 2, 3 top>bottom (press 3, Enter, Up, press 2, Enter, Up, 1 ...)
• clear the search (Up or X)
• hit Ctrl + space to open the popup
• press Down = nothing happens, nothing selected
• press Down = 2 selected
• press Down = 3 selected
• press Down = 3 selected
• press Up = 3 selected

[ronso0]

could fix it by only filtering for Up/Down when the popup is closed, but I don't wanna highjack your PR

[ronso0]

poelzi#5
fixes the selection issue, and uses official lineEdit()->clear(). debouncing is still applied.

[ronso0]

Thank you!