Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CueControl: Remove redundant setting of m_pHotcueStatus #3266

Merged

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Nov 5, 2020

If the new position equals Cue::kNoPosition, detachCue() and
pControl->resetCue() will be called in the event handler and the
status will be set to "Empty" anyway.

If the new position equals `Cue::kNoPosition`, `detachCue()` and
`pControl->resetCue()` will be called in the event handler and the
status will be set to "Empty" anyway.
@Holzhaus Holzhaus added this to the 2.4.0 milestone Nov 5, 2020
@Holzhaus Holzhaus added this to In progress in 2.4 release via automation Nov 5, 2020
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It still works without a regression.

(except the occasional hang of cue preview)

@daschuer daschuer merged commit 529048b into mixxxdj:main Nov 5, 2020
2.4 release automation moved this from In progress to Done Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2.4 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants