Clean up & document .gitignore #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
reviewed
Nov 7, 2020
.gitignore
Outdated
| *.diff | ||
| *.log | ||
| mixxx.log* |
There was a problem hiding this comment.
mixxx.log is not in the source tree isn't it?
There was a problem hiding this comment.
Whenever I execute the tests I get ten mixxxx-log files in the root directory ^^
There was a problem hiding this comment.
yeah, me too.
Should we rather prevent that in the first places and create logs in the build/test dir?
There was a problem hiding this comment.
we should, but I think I tried that and it was a little more complex...
There was a problem hiding this comment.
I think it's related to #2938
Holzhaus
reviewed
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorders some entries in the gitignore and splits it into sections. There are some question marks, I'd appreciate input there - whether they are even still needed.
It also adds the long-needed ignore pattern for logs.