Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate that beatgrid implementation is broken #3418

Closed
wants to merge 1 commit into from

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Dec 8, 2020

Documentation from the Beats class header file:

    // Starting from sample dSamples, return the sample of the next beat in the
    // track, or -1 if none exists. If dSamples refers to the location of a
    // beat, dSamples is returned.
    virtual double findNextBeat(double dSamples) const = 0;

    // Starting from sample dSamples, return the sample of the previous beat in
    // the track, or -1 if none exists. If dSamples refers to the location of
    // beat, dSamples is returned.
    virtual double findPrevBeat(double dSamples) const = 0;

If the code actually behaves as described here, these DEBUG_ASSERT statements should not be a problem. But they make tests fail on my machine.

src/track/beatgrid.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Mar 11, 2021
@Holzhaus
Copy link
Member Author

Fixed in #4099.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major bug stale Stale issues that haven't been updated for a long time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants