Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hercules P32 mapping: more accurate headmix control #3537

Merged

Conversation

pierrelegall
Copy link
Contributor

The headmix is 4 times more accurate as it.

I feel it very handy :)

@pierrelegall pierrelegall force-pushed the mapping/hercules-p32/more-accurate-headmix branch from 423c7ca to 44da75f Compare January 7, 2021 14:53
@pierrelegall
Copy link
Contributor Author

Documentation PR: #3537

@Holzhaus
Copy link
Member

@Be-ing don't you own a P32? Merge?

@Be-ing
Copy link
Contributor

Be-ing commented Jan 12, 2021

Yes, I have not yet tested this. I am doubtful it should be merged.

@pierrelegall
Copy link
Contributor Author

From my point of view, the today head mix control is not accurate at all (9 possible positions vs. 33 in this PR, and moving from full cue to full mix is still available with one hand movement). I found it so much easier to match the headphone preview I need as it.

@Be-ing Can you please explain your doubts?

@Be-ing
Copy link
Contributor

Be-ing commented Jan 21, 2021

Originally I intentionally made this coarse because it's not important to have a smooth crossfade in your headphones that the audience doesn't hear. Generally, I'd think most users would only want this in one of three positions: fully left, center, or fully right. So I thought it was better to make it easy to switch between those states quickly.

After testing this again, I feel that the current coarseness is a bit awkward and unexpected. But I think 0.625 is too fine. How about 0.1?

@pierrelegall
Copy link
Contributor Author

Originally I intentionally made this coarse because it's not important to have a smooth crossfade in your headphones that the audience doesn't hear. Generally, I'd think most users would only want this in one of three positions: fully left, center, or fully right. So I thought it was better to make it easy to switch between those states quickly.

Interesting ; I am new in DJing and I found this feature (firstly on a Numark Mixtrack II Pro, where a potentiometer is dedicate to) very important to beat match, pre-set EQs & co. well in every possible environments :o

After testing this again, I feel that the current coarseness is a bit awkward and unexpected. But I think 0.625 is too fine. How about 0.1?

*0.0625, not 0.625 ;)

I naively tried only 0.125 and 0.0625 because it's a multiple of the previous value (0.25).

I don't feel it awkward but I will give a try with 0.1 :)

The head mix is 4 times more accurate now.
@pierrelegall pierrelegall force-pushed the mapping/hercules-p32/more-accurate-headmix branch from 44da75f to 36fc3bd Compare February 2, 2021 21:41
@Be-ing Be-ing merged commit a1c35fd into mixxxdj:2.3 Feb 2, 2021
@pierrelegall
Copy link
Contributor Author

0.1 is better! :)

Change made.

@Holzhaus
Copy link
Member

Holzhaus commented Feb 6, 2021

@Be-ing please don't merge stuff without also merging the corresponding manual PR: mixxxdj/manual#342

@Be-ing
Copy link
Contributor

Be-ing commented Feb 6, 2021

I didn't realize there was a manual PR for this because it was not linked here nor do I think this tiny change needed one.

@Holzhaus
Copy link
Member

Holzhaus commented Feb 6, 2021

We should track changes using the versionchanged directive so that users aren't confused if controller behavior suddenly changes between releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants