remove ControllerVisitor

[Be-ing]

This class served no purpose but made the code overcomplicated.
DlgController already checks Controller's isMappable method to
determine whether to enable the button to create
DlgControllerLearning.

This is a step towards decoupling the legacy mapping system from the hardware I/O of the Controller classes. No functionality is changed by this PR.

[uklotzde]

Did you check if LegacyControllerMappingVisitor/ConstLegacyControllerMappingVisitor are still required?

Applying those GoF patterns with such a generic naming is fishy. Made these mistakes myself back then, that's why I mention it ;)

[Be-ing]

Did you check if LegacyControllerMappingVisitor/ConstLegacyControllerMappingVisitor are still required?

Removing those will be the next step. Let's keep each step as small as possible.

[Be-ing]

I don't understand the reasoning for introducing such roundabout code rather than using a cast in the first place. It dramatically increases coupling, makes the code extremely confusing, and offers no benefit as far as I can tell.

[uklotzde]

Thank you! LGTM

[uklotzde]

I don't understand the reasoning for introducing such roundabout code rather than using a cast in the first place. It dramatically increases coupling, makes the code extremely confusing, and offers no benefit as far as I can tell.

Pattern driven development ;)

[Be-ing]

Textbook driven development? 🤷 Not appropriate for real code

[Holzhaus]

https://www.ferranpujolcamins.cat/2021/02/09/Is-the-visitor-pattern-still-relevant.html