Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Argument parser. #3640

Merged
merged 10 commits into from
Mar 9, 2021
11 changes: 5 additions & 6 deletions src/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,6 @@ int main(int argc, char * argv[]) {
QCoreApplication::setApplicationName(Version::applicationName());
QCoreApplication::setApplicationVersion(Version::version());

// Construct a list of strings based on the command line arguments
CmdlineArgs& args = CmdlineArgs::Instance();
if (!args.Parse(argc, argv)) {
args.printUsage();
return kParseCmdlineArgsErrorExitCode;
}

// If you change this here, you also need to change it in
// ErrorDialogHandler::errorDialog(). TODO(XXX): Remove this hack.
Expand All @@ -90,6 +84,11 @@ int main(int argc, char * argv[]) {

MixxxApplication app(argc, argv);

// Construct a list of strings based on the command line arguments
CmdlineArgs& args = CmdlineArgs::Instance();
if (!args.Parse(app.arguments())) {
return kParseCmdlineArgsErrorExitCode;
}

#ifdef __APPLE__
QDir dir(QApplication::applicationDirPath());
Expand Down
7 changes: 6 additions & 1 deletion src/test/mixxxtest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@ QScopedPointer<MixxxApplication> MixxxTest::s_pApplication;
MixxxTest::ApplicationScope::ApplicationScope(int& argc, char** argv) {
// Construct a list of strings based on the command line arguments
CmdlineArgs args;
const bool argsParsed = args.Parse(argc, argv);
QStringList argList;
for (int i = 0; i < argc; i++) {
argList << QString::fromLocal8Bit(argv[i]);
}

const bool argsParsed = args.Parse(argList);
Q_UNUSED(argsParsed);
DEBUG_ASSERT(argsParsed);

Expand Down
Loading