Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Controller Learning Wizard if no mapping is selected #3667

Merged
merged 4 commits into from Mar 2, 2021
Merged

Fix Controller Learning Wizard if no mapping is selected #3667

merged 4 commits into from Mar 2, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Mar 1, 2021

Superseeded #3664.

@Holzhaus Holzhaus added this to the 2.3.0 milestone Mar 1, 2021
@Holzhaus Holzhaus added this to In progress in 2.3 release via automation Mar 1, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Mar 2, 2021

Good work, thanks.

@Be-ing Be-ing merged commit 58d80fa into mixxxdj:2.3 Mar 2, 2021
2.3 release automation moved this from In progress to Done Mar 2, 2021
@Be-ing
Copy link
Contributor

Be-ing commented Mar 2, 2021

Resolving conflicts with main on its own is not too difficult, but it doesn't work as 2.3 does due to changes in main... This will take a bit of work.

@Holzhaus
Copy link
Member Author

Holzhaus commented Mar 5, 2021

https://mixxx.zulipchat.com/#narrow/stream/113295-controller-mapping/topic/C.2B.2B.20controller.20system.20refactoring/near/228962117

@Be-ing Be-ing mentioned this pull request Mar 5, 2021
Merged
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing left review comments

Assignees
No one assigned
Labels
minor bug preferences
Projects
2.3 release
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Holzhaus @Be-ing