Ask for rescan upgrade #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2014 15:31
This is necessary so that we can display cover-art for users that are upgrading.
Coding style changes and removal of dead code.
| @@ -331,6 +330,9 @@ ConfigObject<ConfigValue>* Upgrade::versionUpgrade(const QString& settingsPath) | |||
| if (configVersion.startsWith("1.11")) { | |||
| qDebug() << "Upgrading from v1.11.x..."; | |||
|
|
|||
| //////////// | |||
There was a problem hiding this comment.
I don't like this style of comment, it is very LOUD. Please just replace with
// Upgrade to multi-library folder settings
(also there was a spelling mistake)
|
@ywwg thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.launchpad.net/mixxx/+bug/1390019
Tell the user that we have to rescan the library for coverart when they are upgrading from 1.11.
It would be nice if a native speaker could look over the text that is displayed in the QMessageBox in upgrade.cpp