WTrackTableView: don't use header section highlight… #3818

ronso0 · 2021-04-30T22:54:39Z

...explicitely style with qss only.

As soon as the tableview is focused all column labels would be automatically rendered bold -- and previous style is not restored when the tableview is unfocused, only when the table content changes. This can not be overwritten with qss, so it can screw up the skin design.
Also, due to selectionModel()->selectedRows() it is not even useful to highlight the focused column.

I did not find a qss way to override the hader font for focused table views -- doing this in c++ is the last resort (and I have no idea why it would be enabled in the first place because I don't see UI benefit).
No side effects to be expected https://doc.qt.io/qt-5/qheaderview.html#highlightSections-prop

double check skins after Skins: style main menubar #3788 is merged

Holzhaus · 2021-05-03T21:06:51Z

Looks good I think.

Ready for merge?

ronso0 · 2021-05-03T22:06:33Z

not really. the reason for this PR is that I use Open Sans Semibold for the header, but setHighlightSections(true); would make it bold. I rebased onto 2.3 and LateNight and it should look like this:

Other skins are using bold anyway.

ronso0 · 2021-05-03T23:15:08Z

@Holzhaus Can you check what fonts are recognized on your machine?
I checked with Windows 10 and the font changes in #3788 fixed the font issues there.
this is what I see:

 <!-- this exact same block is printed three times in a row -->
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Condensed Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Semibold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "SemiBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Extrabold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Extrabold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Condensed Light" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Regular" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Semibold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
...
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
...

Holzhaus · 2021-05-04T10:55:15Z

Debug [Main]: Loading resources from  "/home/jan/Projects/mixxx/res/"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Regular" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "SemiBold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "SemiBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Regular" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "SemiBold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "SemiBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Regular" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "SemiBold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "SemiBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Bold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "ExtraBold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Open Sans" style: "Semibold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Bold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Light" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Medium Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Regular" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Bold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Medium" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Bold" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Light Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Light" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Medium Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Regular" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Bold Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Italic" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Debug [Main]: FONT LOADED family: "Ubuntu" style: "Medium" point sizes: "6,7,8,9,10,11,12,14,16,18,20,22,24,26,28,36,48,72"
Info [Main]: DbConnection - Available drivers for database connections: ("QIBASE", "QSQLITE", "QMARIADB", "QMYSQL", "QMYSQL3", "QODBC", "QODBC3", "QPSQL", "QPSQL7", "QTDS", "QTDS7")

Holzhaus · 2021-05-04T10:56:26Z

Headers are still bold:

…e with qss only

ronso0 · 2021-05-04T15:43:33Z

We know Qt versions make a difference so I assume it's an qss issue again.

To be 100% sure the c++ change is in place I explicitely setHighlightSections(false), rebased and force-pushed.
I also adjusted the qss to explicitely include QHeaderView::section. Maybe that makes a difference for you.

For me, the original issue with bold headers is resolved, the headers are semi-bold, both in the focused and unfocused table:

Ready for merge.

Meanwhile I'll build the Qt 5.15.2 sources and see if I can debug the remaining font & icon issues.

Holzhaus · 2021-05-04T18:28:23Z

I think it works now, thanks.

ronso0 added this to In progress in 2.3 release via automation Apr 30, 2021

github-actions bot added the ui label Apr 30, 2021

ronso0 added library skins and removed ui labels Apr 30, 2021

ronso0 force-pushed the headerhighlight branch from 004108c to 2cc0cad Compare May 3, 2021 22:06

github-actions bot added the ui label May 3, 2021

ronso0 marked this pull request as ready for review May 3, 2021 23:15

ronso0 force-pushed the headerhighlight branch from 2cc0cad to a5d3c41 Compare May 4, 2021 15:22

WTrackTableView: don't use header section highlight, explicitely styl…

bc82898

…e with qss only

ronso0 force-pushed the headerhighlight branch from a5d3c41 to bc82898 Compare May 4, 2021 15:42

Holzhaus merged commit 3caed0a into mixxxdj:2.3 May 4, 2021

2.3 release automation moved this from In progress to Done May 4, 2021

ronso0 deleted the headerhighlight branch May 4, 2021 19:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WTrackTableView: don't use header section highlight… #3818

WTrackTableView: don't use header section highlight… #3818

ronso0 commented Apr 30, 2021 •

edited

Holzhaus commented May 3, 2021

ronso0 commented May 3, 2021

ronso0 commented May 3, 2021

Holzhaus commented May 4, 2021

Holzhaus commented May 4, 2021

ronso0 commented May 4, 2021

Holzhaus commented May 4, 2021

WTrackTableView: don't use header section highlight… #3818

WTrackTableView: don't use header section highlight… #3818

Conversation

ronso0 commented Apr 30, 2021 • edited

Holzhaus commented May 3, 2021

ronso0 commented May 3, 2021

ronso0 commented May 3, 2021

Holzhaus commented May 4, 2021

Holzhaus commented May 4, 2021

ronso0 commented May 4, 2021

Holzhaus commented May 4, 2021

ronso0 commented Apr 30, 2021 •

edited