Use Git describe for the mixxx ppa #3824
Conversation
CMakeLists.txt
Outdated
| string(REPLACE "_" "" CPACK_DEBIAN_DEBIAN_VERSION_EXTRA "${CPACK_DEBIAN_DEBIAN_VERSION_EXTRA}") | ||
| set(CPACK_DEBIAN_PACKAGE_VERSION "${CPACK_DEBIAN_UPSTREAM_VERSION}-ppa1~${GIT_BRANCH}~git${GIT_COMMIT_COUNT}~bionic") | ||
| string(REPLACE "-" "~" CPACK_DEBIAN_PACKAGE_VERSION "${PACKAGE_VERSION}") | ||
| set(CPACK_DEBIAN_PACKAGE_RELEASE mixxx1) |
There was a problem hiding this comment.
Typo? If not, please add a comment why it's mixxx1.
There was a problem hiding this comment.
No, but we may change it because that a bit unusual.
This is the package version. Ubuntu uses 0ubuntu1 where the first number is the debian version and the last number the patched version. Debian version packages dfsg1. The lint tools is complaining that we must not use one of these ending because we have not the debian/ubuntu email address.
Alternatives
ppa1
build1
Other option?
There was a problem hiding this comment.
I don't care, we can keep using mixxx1, just add that explanation as a comment so other people don't think it's a typo when reading the code.
There was a problem hiding this comment.
I have picked now just 1 for the least confusing version.
|
The pudding tastes bad. Maybe a bit more sugar. I will have a look. Something with that new path. |
Ok, thanks for taking care. By the way, where do you see that it failed? Do you have a link? Launchpad is confusing. |
|
This is really confusing. In such issues the upload is rejected and fails silently. |
Locally it works. Hopefully after merge as well.