Show the rainbow donate button in some cases (1/6 ratio) #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
May 8, 2021
|
|
||
| if (!Color::isDimColor(palette().text().color())) { | ||
| btnDonate->setIcon(QIcon(":/images/heart_icon_light.svg")); | ||
| if (std::rand() % 6) { |
There was a problem hiding this comment.
This isn't 1/6 chance, this is 1/RAND_MAX chance, or did I miss something?
There was a problem hiding this comment.
Ah no, mod 6 should work. I was confused ;-)
Holzhaus
reviewed
May 8, 2021
res/images/heart_icon_rainbow.svg
Outdated
| </g> | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg id="svg4023" width="32" height="32" version="1.1" viewBox="0 -256 32 32" xmlns="http://www.w3.org/2000/svg" xmlns:cc="http://creativecommons.org/ns#" xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <metadata id="metadata4027"> |
There was a problem hiding this comment.
Can you save this as an optimized SVG from Inkscape? This brings down file size.
|
double-check the SVG after optimizing, it's not 100% reliable |
|
OK, I have stripped the svg a bit more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for a little bit of surprise ...