Track metadata: Renamings, reorderings, minor bugfix #3866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
reviewed
May 16, 2021
| @@ -227,10 +228,10 @@ void Track::importMetadata( | |||
| } | |||
| } | |||
|
|
|||
| bool Track::mergeImportedMetadata( | |||
| bool Track::mergeExtraMetadataFromSource( | |||
There was a problem hiding this comment.
From the naming I'd assume this only imports metadata that is not yet present (or empty). Is that correct?
There was a problem hiding this comment.
Not quite. It only affects metadata that is not yet stored in the database -> "extra"
We have a corresponding test to verify that fields like artist or genre are not modified, even if empty or missing.
Holzhaus
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another bite-sized PR with renamings and reorderings to prepare the next steps.
Minor fix: Removal of a default parameter revealed a minor bug that does not have any consequences yet.