QML: Add ImageProvider for Cover Art #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holzhaus
force-pushed
the
qml-coverart
branch
5 times, most recently
from
029d252
to
d4681e3
Compare
Holzhaus
force-pushed
the
qml-coverart
branch
2 times, most recently
from
c14b8b6
to
468869f
Compare
Holzhaus
changed the title
Holzhaus
force-pushed
the
qml-coverart
branch
3 times, most recently
from
cf453e1
to
ec88b47
Compare
uklotzde
suggested changes
Jun 4, 2021
src/skin/qml/asyncimageprovider.cpp
Outdated
| } | ||
|
|
||
| void AsyncImageResponse::run() { | ||
| if (m_id.startsWith(QStringLiteral("coverart/"))) { |
There was a problem hiding this comment.
We should use a constant for this prefix and 9 = length
There was a problem hiding this comment.
And then:
QString decodeTrackLocationFromId(const QString& coverartId)
Holzhaus
commented
Jun 4, 2021
uklotzde
reviewed
Jun 5, 2021
uklotzde
reviewed
Jun 5, 2021
uklotzde
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows displaying cover art in QML skins.
Depends on #3911.