Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partially revert #3902 Skins: fix qss icons with kIconThemes 5.80 #3931

Merged
merged 1 commit into from Jun 1, 2021

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented May 31, 2021

because with scale factors >100% the (vector) icons set with 'background[-mage]' are not truely scaled up, only their 100% pixmap, which results in blurry/pixelated icons.
Users still with broken libKIconThemes5 v5.80 have to live with squeezed icons until they (can) update that lib.

https://mixxx.zulipchat.com/#narrow/stream/109171-development/topic/2.2E3.20planning.3A.20https.3A.2F.2Fgithub.2Ecom.2Fmixxxdj.2Fmixxx.2Fprojects.2F2/near/240843338

@ronso0 ronso0 added this to the 2.3.0 milestone May 31, 2021
@ronso0 ronso0 added this to In progress in 2.3 release via automation May 31, 2021
@ronso0
Copy link
Member Author

ronso0 commented May 31, 2021

voila, more time wasted. looking forward to fix the conflicts with main

@ronso0 ronso0 force-pushed the revert-qss-icon-fix_single branch from c978596 to 34188fb Compare May 31, 2021 23:41
because with scale factors >100% the (vector) icons set with 'background[-mage]'
are not truely scaled up, only their 100% pixmap, which results in blurry/
pixelated icons.
Users still with broken libKIconThemes5 v5.80 have to live with squeezed icons
until they (can) update that lib.
@ronso0 ronso0 force-pushed the revert-qss-icon-fix_single branch from 34188fb to 8d81163 Compare June 1, 2021 00:09
@ywwg
Copy link
Member

ywwg commented Jun 1, 2021

can confirm this results in squeezed images on ubuntu 21.04

@Holzhaus
Copy link
Member

Holzhaus commented Jun 1, 2021

I can confirm this fixes the pixelated icons with double scaling. It also fixes the square BPM Slider center indicator in LateNight (this even happens without scaling). Merge?

@ronso0
Copy link
Member Author

ronso0 commented Jun 1, 2021

I couldn't simply revert the PR because it contained other fixes, and because I pushed another small fix later.
I'm not worried it works, im just a little worried that I also restored all button colors.
I seriously don't want to touch qss again before the release, so I'd like to be sure it's complete. testing a few buttons in every skin region should suffice.

@ywwg
Copy link
Member

ywwg commented Jun 1, 2021

with the new deb from the PPA, skins look good on ubuntu. ok to merge by me

@ronso0
Copy link
Member Author

ronso0 commented Jun 1, 2021

I found some issues like double preview icons in the library (from default.qss and skin style)
am about to fix those. since no one else noticed anything weird I'll simply merge when I'm done.

@ronso0
Copy link
Member Author

ronso0 commented Jun 1, 2021

double preview icons in the library

fixed of course after rebuilding.
though there was a wrong icon in the Deere sampler.

D O N E !!!

@ronso0 ronso0 merged commit bfdbabb into mixxxdj:2.3 Jun 1, 2021
2.3 release automation moved this from In progress to Done Jun 1, 2021
@ronso0 ronso0 deleted the revert-qss-icon-fix_single branch June 1, 2021 20:51
ronso0 added a commit that referenced this pull request Jun 1, 2021
@ronso0
Copy link
Member Author

ronso0 commented Jun 1, 2021

stupid me,. I had two 'revert' branches and applied that small fixes to the wrong one. I'll push those directly.

@ronso0
Copy link
Member Author

ronso0 commented Jun 1, 2021

and I'm merging to main now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2.3 release
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants