skins/QMLDemo: Add channel VU meters #3932
Conversation
| property string key // required | ||
| property color barColor // required | ||
|
|
||
| radius: width / 2 |
There was a problem hiding this comment.
for performance reasons, we could consider disabling antialiasing for this Rectangle because i don't think it makes a difference here. https://doc.qt.io/qt-5/qml-qtquick-rectangle.html#performance
| anchors.bottom: parent.bottom | ||
| anchors.margins: 1 | ||
| height: control.parameter * (parent.height - 2 * anchors.margins) | ||
| radius: width / 2 |
There was a problem hiding this comment.
Same antialiasing performance optimization here.
|
An alternative to masking would also be to abuse clipping, but I'm not sure if that would improve or worsen performance. |
|
My original implementation was just modifying the height of the rectangle, but that doesn't work if I want to use multiple colors (because the gradient would shrink accordingly). |
|
Yeah that makes sense. I'm just worried about creating too many transparent objects which result in a bunch of draw calls that can't be batched together. abusing clipping would still result in the same amount of draw calls, but might be faster because it can be done by the GPU and is less complicated (its just clipping a rectangle instead of masking on texture based on another texture). |
|
I'll go ahead and merge now that antialiasing has been disabled for the component. |
No description provided.